Merge pull request #1273 from magento/1227_Create_an_entity_-_The_tra…

…nslation_function_is_not_call_on_the_buttons_label 1227: fix Create an entity - The translation function is not call on …
magento · Dec 23, 2022 · 24bd90f · 24bd90f
2 parents c3d701f + 2b08768
commit 24bd90f
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).
 ### Fixed
 
 - Throwable: Stub index points to a file without PSI [#1232](https://github.com/magento/magento2-phpstorm-plugin/pull/1232)
-- Create an entity - delete button is displayed in a new entity form [#1268](https://github.com/magento/magento2-phpstorm-plugin/pull/1268)
+- Create an entity - The delete button is displayed in a new entity form [#1268](https://github.com/magento/magento2-phpstorm-plugin/pull/1268)
+- Create an entity - The translation function is not call on the buttons label [#1273](https://github.com/magento/magento2-phpstorm-plugin/pull/1273)
 - Covered possible NullPointerException in InjectAViewModelDialog.java [#1213](https://github.com/magento/magento2-phpstorm-plugin/pull/1213)
 - AWT events are not allowed inside write action [#1271](https://github.com/magento/magento2-phpstorm-plugin/pull/1271)
 - MapReduceIndexMappingException: java.lang.NumberFormatException: For input string: "" [#1235](https://github.com/magento/magento2-phpstorm-plugin/pull/1235)

diff --git a/resources/fileTemplates/internal/Magento Form Button Block Class.php.ft b/resources/fileTemplates/internal/Magento Form Button Block Class.php.ft
@@ -27,7 +27,7 @@ class ${NAME} extends ${GENERIC_BUTTON} implements ${DATA_PROVIDER_TYPE}
 
 #end
         return $this->wrapButtonSettings(
-            '${LABEL}',
+            __('${LABEL}'),
             '${CLASS}',
             ${ON_CLICK},
             ${DATA_ATTRS},

diff --git a/...ns/generation/generator/FormButtonBlockGenerator/generateBackButtonBlock/MyBackButton.php b/...ns/generation/generator/FormButtonBlockGenerator/generateBackButtonBlock/MyBackButton.php
@@ -17,7 +17,7 @@ class MyBackButton extends GenericButton implements ButtonProviderInterface
     public function getButtonData(): array
     {
         return $this->wrapButtonSettings(
-            'Back To Grid',
+            __('Back To Grid'),
             'back',
             sprintf("location.href = '%s';", $this->getUrl('*/*/')),
             [],

diff --git a/...ions/generation/generator/FormButtonBlockGenerator/generateCustomButtonBlock/MyCustom.php b/...ions/generation/generator/FormButtonBlockGenerator/generateCustomButtonBlock/MyCustom.php
@@ -17,7 +17,7 @@ class MyCustom extends GenericButton implements ButtonProviderInterface
     public function getButtonData(): array
     {
         return $this->wrapButtonSettings(
-            'Custom Button',
+            __('Custom Button'),
             'custom',
             '',
             [],

diff --git a/...s/generation/generator/FormButtonBlockGenerator/generateDeleteButtonBlock/DeleteBlock.php b/...s/generation/generator/FormButtonBlockGenerator/generateDeleteButtonBlock/DeleteBlock.php
@@ -22,7 +22,7 @@ public function getButtonData(): array
         }
 
         return $this->wrapButtonSettings(
-            'Delete',
+            __('Delete'),
             'delete',
             sprintf("deleteConfirm('%s', '%s')",
                 __('Are you sure you want to delete this book?'),

diff --git a/...tions/generation/generator/FormButtonBlockGenerator/generateSaveButtonBlock/SaveBlock.php b/...tions/generation/generator/FormButtonBlockGenerator/generateSaveButtonBlock/SaveBlock.php
@@ -17,7 +17,7 @@ class SaveBlock extends GenericButton implements ButtonProviderInterface
     public function getButtonData(): array
     {
         return $this->wrapButtonSettings(
-            'Save',
+            __('Save'),
             'save primary',
             '',
             [