Fixed CheckStyle issues

magento · Oct 30, 2020 · b830fb7 · b830fb7
1 parent 00305e5
commit b830fb7
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 10 deletions.
diff --git a/src/com/magento/idea/magento2plugin/actions/generation/CreateAPluginAction.java b/src/com/magento/idea/magento2plugin/actions/generation/CreateAPluginAction.java
@@ -2,6 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 package com.magento.idea.magento2plugin.actions.generation;
 
 import com.intellij.openapi.actionSystem.AnActionEvent;
@@ -17,10 +18,10 @@
 import com.jetbrains.php.lang.psi.elements.PhpClass;
 import com.magento.idea.magento2plugin.MagentoIcons;
 import com.magento.idea.magento2plugin.actions.generation.dialog.CreateAPluginDialog;
+import com.magento.idea.magento2plugin.project.Settings;
 import com.magento.idea.magento2plugin.util.GetFirstClassOfFile;
 import com.magento.idea.magento2plugin.util.magento.plugin.IsPluginAllowedForMethod;
 import org.jetbrains.annotations.NotNull;
-import com.magento.idea.magento2plugin.project.Settings;
 
 public class CreateAPluginAction extends DumbAwareAction {
     public static final String ACTION_NAME = "Create a new Plugin for this method";
@@ -30,12 +31,18 @@ public class CreateAPluginAction extends DumbAwareAction {
     private Method targetMethod;
     private PhpClass targetClass;
 
+    /**
+     * Constructor.
+     */
     public CreateAPluginAction() {
         super(ACTION_NAME, ACTION_DESCRIPTION, MagentoIcons.MODULE);
         this.isPluginAllowed = IsPluginAllowedForMethod.getInstance();
         this.getFirstClassOfFile = GetFirstClassOfFile.getInstance();
     }
 
+    /**
+     * @inheritdoc
+     */
     @Override
     public void update(final AnActionEvent event) {
         targetClass = null;// NOPMD
@@ -88,7 +95,11 @@ private Pair<PsiFile, PhpClass> findPhpClass(@NotNull final AnActionEvent event)
         return Pair.create(psiFile, phpClass);
     }
 
-    private void fetchTargetMethod(@NotNull final AnActionEvent event, final PsiFile psiFile, final PhpClass phpClass) {
+    private void fetchTargetMethod(
+            @NotNull final AnActionEvent event,
+            final PsiFile psiFile,
+            final PhpClass phpClass
+    ) {
         final Caret caret = event.getData(PlatformDataKeys.CARET);
         if (caret == null) {
             return;
@@ -98,12 +109,14 @@ private void fetchTargetMethod(@NotNull final AnActionEvent event, final PsiFile
         if (element == null) {
             return;
         }
-        if (element instanceof Method && element.getParent() == phpClass && isPluginAllowed.check((Method) element)) {
+        if (element instanceof Method && element.getParent()
+                == phpClass && isPluginAllowed.check((Method) element)) {
             this.targetMethod = (Method) element;
             return;
         }
         final PsiElement parent = element.getParent();
-        if (parent instanceof Method && parent.getParent() == phpClass && isPluginAllowed.check((Method) parent)) {
+        if (parent instanceof Method && parent.getParent()
+                == phpClass && isPluginAllowed.check((Method) parent)) {
             this.targetMethod = (Method) parent;
         }
     }

diff --git a/src/com/magento/idea/magento2plugin/actions/generation/CreateAnObserverAction.java b/src/com/magento/idea/magento2plugin/actions/generation/CreateAnObserverAction.java
@@ -2,6 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 package com.magento.idea.magento2plugin.actions.generation;
 
 import com.intellij.lang.ASTNode;
@@ -35,6 +36,9 @@ public CreateAnObserverAction() {
         super(ACTION_NAME, ACTION_DESCRIPTION, MagentoIcons.MODULE);
     }
 
+    /**
+     * @inheritdoc
+     */
     @Override
     public void update(final AnActionEvent event) {
         final Project project = event.getData(PlatformDataKeys.PROJECT);
@@ -78,10 +82,12 @@ private PsiElement getElement(@NotNull final AnActionEvent event) {
     }
 
     private boolean isObserverEventNameClicked(@NotNull final PsiElement element) {
-        return checkIsElementStringLiteral(element) &&
-                checkIsParametersList(element.getParent().getParent()) &&
-                checkIsMethodReference(element.getParent().getParent().getParent()) &&
-                checkIsEventDispatchMethod((MethodReference) element.getParent().getParent().getParent());
+        return checkIsElementStringLiteral(element)
+                && checkIsParametersList(element.getParent().getParent())
+                && checkIsMethodReference(element.getParent().getParent().getParent())
+                && checkIsEventDispatchMethod(
+                        (MethodReference) element.getParent().getParent().getParent()
+                );
     }
 
     private boolean checkIsParametersList(@NotNull final PsiElement element) {
@@ -119,7 +125,8 @@ private boolean checkIsElementStringLiteral(@NotNull final PsiElement element) {
         }
         final IElementType elementType = astNode.getElementType();
 
-        return elementType == PhpTokenTypes.STRING_LITERAL || elementType == PhpTokenTypes.STRING_LITERAL_SINGLE_QUOTE;
+        return elementType == PhpTokenTypes.STRING_LITERAL
+                || elementType == PhpTokenTypes.STRING_LITERAL_SINGLE_QUOTE;
     }
 
     private void setStatus(final AnActionEvent event, final boolean status) {

diff --git a/src/com/magento/idea/magento2plugin/actions/generation/NewBlockAction.java b/src/com/magento/idea/magento2plugin/actions/generation/NewBlockAction.java
@@ -2,10 +2,15 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 package com.magento.idea.magento2plugin.actions.generation;
 
 import com.intellij.ide.IdeView;
-import com.intellij.openapi.actionSystem.*;
+import com.intellij.openapi.actionSystem.AnAction;
+import com.intellij.openapi.actionSystem.AnActionEvent;
+import com.intellij.openapi.actionSystem.CommonDataKeys;
+import com.intellij.openapi.actionSystem.DataContext;
+import com.intellij.openapi.actionSystem.LangDataKeys;
 import com.intellij.openapi.project.Project;
 import com.intellij.psi.PsiDirectory;
 import com.magento.idea.magento2plugin.MagentoIcons;

diff --git a/src/com/magento/idea/magento2plugin/actions/generation/OverrideClassByAPreferenceAction.java b/src/com/magento/idea/magento2plugin/actions/generation/OverrideClassByAPreferenceAction.java
@@ -2,6 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 package com.magento.idea.magento2plugin.actions.generation;
 
 import com.intellij.openapi.actionSystem.AnActionEvent;
@@ -29,6 +30,9 @@ public OverrideClassByAPreferenceAction() {
         this.getFirstClassOfFile = GetFirstClassOfFile.getInstance();
     }
 
+    /**
+     * @inheritdoc
+     */
     @Override
     public void update(final AnActionEvent event) {
         targetClass = null;// NOPMD