Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

967 add context action to create layout xml file #1021

Conversation

SilinMykola
Copy link

@SilinMykola SilinMykola commented Feb 28, 2022

Description (*)

This PR adds the ability to create a new layout from the context menu.

image
image
image

Fixed Issues (if relevant)

  1. Fixes Add a new context dependent Action for the layout xml file generation #967

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@SilinMykola SilinMykola force-pushed the 967-add-context-action-to-create-layout-xml-file branch from 9717f71 to d93801f Compare March 7, 2022 15:47
@bohdan-harniuk bohdan-harniuk force-pushed the 967-add-context-action-to-create-layout-xml-file branch from ae7bb34 to 6c4f1ed Compare March 7, 2022 15:56
…plugin into 967-add-context-action-to-create-layout-xml-file
@bohdan-harniuk bohdan-harniuk force-pushed the 967-add-context-action-to-create-layout-xml-file branch from 6c4f1ed to 79bcc60 Compare March 7, 2022 15:57
@bohdan-harniuk bohdan-harniuk force-pushed the 967-add-context-action-to-create-layout-xml-file branch from 80a2d74 to 42ca0e0 Compare March 7, 2022 16:12
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @SilinMykola!

Thank you for your work!
Could you please remove that from the context layout generation?

Screenshot 2022-03-07 at 18 17 48

Regards,

@bohdan-harniuk bohdan-harniuk self-requested a review March 10, 2022 14:53
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @SilinMykola!

Great job!

Thank you!

@SilinMykola SilinMykola changed the title 966 add context action to create layout xml file 967 add context action to create layout xml file Mar 10, 2022
@bohdan-harniuk bohdan-harniuk merged commit 875b63d into magento:4.3.0-develop Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new context dependent Action for the layout xml file generation
2 participants