Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

614: Provided file path references for JS:STRING_LITERAL psi elements in the js files #1045

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)

Provided file path references for JS:STRING_LITERAL psi elements in the JS files.

Mar-24-2022 17-37-29
Mar-24-2022 17-22-26

Fixed Issues (if relevant)

  1. Fixes Jump to code in mixins #614

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@VitaliyBoyko VitaliyBoyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bohdan-harniuk

Looks great. Add some tests pls and good to go.

@bohdan-harniuk
Copy link
Collaborator Author

Hello, @VitaliyBoyko!

I've added test coverage.
Please, proceed with the code review.

Regards,

…plugin into 614-references-for-file-path-js-string-literals
…plugin into 614-references-for-file-path-js-string-literals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jump to code in mixins
2 participants