Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1113: Fixed IllegalArgumentException: Argument for @NotNull parameter 'dataKey' must not be null in CompareTemplateAction #1117

Merged
merged 2 commits into from
Jun 17, 2022
Merged

1113: Fixed IllegalArgumentException: Argument for @NotNull parameter 'dataKey' must not be null in CompareTemplateAction #1117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57dbea9
1113: Fixed not null parameter
Iamwade Jun 17, 2022
7a5d78f
1113: Fixed PMD
Iamwade Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/com/magento/idea/magento2plugin/actions/comparator/CompareTemplateAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ public CompareTemplateAction() {
*
* @param event AnActionEvent
*/
@SuppressWarnings("PMD.NPathComplexity")
@Override
@SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPathComplexity"})
public void update(final @NotNull AnActionEvent event) {
setStatus(event, false);
final Project project = event.getData(PlatformDataKeys.PROJECT);
Expand Down Expand Up @@ -83,6 +83,9 @@ public void update(final @NotNull AnActionEvent event) {
}
final String originalModuleName = getOriginalModuleName(project, psiFile);

if (originalModuleName == null) {
return;
}
final PsiDirectory originalModuleDirectory =
new ModuleIndex(project).getModuleDirectoryByModuleName(originalModuleName);

Expand Down