Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#186: Extend the new Magento 2 module generation with the ability to … #266

Merged
merged 6 commits into from
Feb 12, 2021
Merged

#186: Extend the new Magento 2 module generation with the ability to … #266

merged 6 commits into from
Feb 12, 2021

Conversation

mmezhensky
Copy link

Description (*)

This PR extends the new Magento 2 module generation with the ability to set module sequence(s).

Fixed Issues (if relevant)

  1. Extend action / Code Generation. Add ability to set the module sequence at generating new module. #186: Extend action / Code Generation. Add ability to set the module sequence at generating new module.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VitaliyBoyko VitaliyBoyko self-assigned this Jul 8, 2020
@VitaliyBoyko VitaliyBoyko changed the base branch from 1.0.2-develop to 2.0.0-develop September 4, 2020 07:27
@coderimus coderimus self-requested a review September 18, 2020 15:24
VitaliyBoyko
VitaliyBoyko previously approved these changes Oct 13, 2020
View reviewed changes
@VitaliyBoyko VitaliyBoyko self-requested a review October 16, 2020 06:26
@VitaliyBoyko VitaliyBoyko changed the base branch from 2.0.0-develop to 3.2.0-develop February 8, 2021 08:31
@VitaliyBoyko VitaliyBoyko dismissed their stale review February 8, 2021 08:31

The base branch was changed.

@VitaliyBoyko
Copy link
Contributor

@mmezhensky

Are you up to proceed with this?

@mmezhensky
Copy link
Author

@VitaliyBoyko
Sorry, but I don't have time for this right now.
You can pick up this task if you need to push it faster.

Vitaliy Boyko added 2 commits February 12, 2021 16:24
Merge branch '3.2.0-develop' of github.com:magento/magento2-phpstorm-…
c45dbb8 
…plugin into issue-186

� Conflicts:
�	src/com/magento/idea/magento2plugin/actions/generation/data/ModuleXmlData.java
�	src/com/magento/idea/magento2plugin/actions/generation/generator/ModuleXmlGenerator.java
�	src/com/magento/idea/magento2plugin/generation/php/MagentoModuleGenerator.java
�	src/com/magento/idea/magento2plugin/magento/files/ModuleXml.java
Fixed tests
cc3a94b
@eduard13 eduard13 self-requested a review February 12, 2021 15:20
eduard13
eduard13 approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍
@VitaliyBoyko do you have anything to add?

@eduard13 eduard13 merged commit 264c5ef into magento:3.2.0-develop Feb 12, 2021
@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Feb 12, 2021 •
edited
Loading

You so fast @eduard13 🤣

@VitaliyBoyko
Copy link
Contributor

Teamwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

@coderimus coderimus Awaiting requested review from coderimus

@VitaliyBoyko VitaliyBoyko Awaiting requested review from VitaliyBoyko

Assignees

@eduard13 eduard13

@VitaliyBoyko VitaliyBoyko

Labels
Award: bug fix Award: test coverage Partner: Atwix partners-contribution Progress: done QA passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmezhensky @VitaliyBoyko @eduard13 @magento-engcom-team