Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect completion for general MFTF text tag attributes #364

Merged
merged 3 commits into from
Oct 31, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 30, 2020

Description

Fixed incorrect completion suggestions for MFTF tags: <stories/>, <title/>, and <description/> which have a common value attribute. These tags are for general text strings should not have completion suggestions.

Fixed Issues

  1. Fixes MFTF: <stories> gets recommendations from other objects #255: MFTF: <stories> gets recommendations from other objects

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@drpayyne
Copy link
Contributor Author

Hello, would this be a good scenario to add a test case for?

@coderimus coderimus merged commit a61d897 into magento:2.1.0-develop Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MFTF: <stories> gets recommendations from other objects
3 participants