Customer EAV attribute generation

[ProkopovVitaliy]

Description (*)

Added customer eav attribute generation

For example lent's add multiselect attribute with options:

1. Open and fill attribute dialog:
   

2. Check generated Data Patch file:
   

3. After setup:upgrade execution check customer in admin panel:
   

Let's create required attribute that will show in customers grid:

1. Open and fill dialog form:
   

2. Check generated Data Patch file:
   

3. After setup:upgrade execution check customer in admin panel:
   
   

Fixed Issues (if relevant)

1. Fixes magento/magento2-phpstorm-plugin#<issue_number>

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with integration/functional tests (if applicable)
• All automated tests passed successfully (all builds are green)

[drpayyne]

Hi @ProkopovVitaliy, thanks for your very useful contribution. But can we please not use deprecated methods? Like the model save() which you're using in the data patch?

@VitaliyBoyko, I'm assuming we don't want to use deprecated methods or bad practices in this project. Since every Magento developer in the world will be using this and we're only spreading bad code by doing so since we are the platform. :)

[VitaliyBoyko]

Please use a resource model instead

[eduard13]

@ProkopovVitaliy thank you for the feature, could you please check the below comments? Additionally, I'd have the following points, that can be done separately:

• Can we have the dialog height more compact? Now, the fields' spaces are dependent by the number of shown fields.
• Add some dependencies between Input and Type? Which means, that if you selected text for Input, the only available options for Type (which should be Backend Type) would be text, 'varchar'. Magento default the following info \Magento\CustomAttributeManagement\Helper\Data::getAttributeInputTypes while creating the attributes from the backend.
  Thank you.

[eduard13]

Why this form isn't getting used at all? Based on the UI, we have only the following available forms

[eduard13]

I don't think that it makes sense to give the possibility to configure both user_defined and system. Since user_defined = true, automatically means system = false, and vice versa.

[eduard13]

Suggested change

*

[eduard13]

Please remove all such occurrences.

Suggested change

*

[bohdan-harniuk]

Hello, @ProkopovVitaliy!

Could you please tell me when you can finish development here?

Regards,

[VitaliyBoyko]

@bohdan-harniuk I'll cover @ProkopovVitaliy back here.

[VitaliyBoyko]

Add some dependencies between Input and Type? Which means, that if you selected text for Input, the only available options for Type (which should be Backend Type) would be text, 'varchar'. Magento default the following info \Magento\CustomAttributeManagement\Helper\Data::getAttributeInputTypes while creating the attributes from the backend.
Thank you.

I suggest making such improvements in a separate PR. All other things were fixed.