Develop plugin declaration inspections #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBoyko
requested changes
May 10, 2021
| } | ||
|
|
||
| /** | ||
| * Test for an no error for the "type" attribute because this class exists. |
There was a problem hiding this comment.
Test for no error for the "type" attribute because this class exists.
Suggested change
| * Test for an no error for the "type" attribute because this class exists. | |
| * Test for no error for the "type" attribute because this class exists. |
resources/META-INF/plugin.xml
Outdated
| bundle="magento2.inspection" key="inspection.displayName.PluginAttrTypeInspection" | ||
| groupBundle="magento2.inspection" groupKey="inspection.group.name" | ||
| enabledByDefault="true" level="WARNING" | ||
| implementationClass="com.magento.idea.magento2plugin.inspections.xml.PluginAttrTypeInspection"/> |
There was a problem hiding this comment.
Suggested change
| implementationClass="com.magento.idea.magento2plugin.inspections.xml.PluginAttrTypeInspection"/> | |
| implementationClass="com.magento.idea.magento2plugin.inspections.xml.PluginAttributeTypeInspection"/> |
| import com.magento.idea.magento2plugin.magento.files.ModuleDiXml; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| public class PluginAttrTypeInspection extends XmlSuppressableInspectionTool { |
There was a problem hiding this comment.
Suggested change
| public class PluginAttrTypeInspection extends XmlSuppressableInspectionTool { | |
| public class PluginAttributeTypeInspection extends XmlSuppressableInspectionTool { |
Let's avoid such a shortening.
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
@VitaliyBoyko fixed, Thank you. |
VitaliyBoyko
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added inspection to the di.xml file for plugin tag.
The inspection is performed for plugin attribute "type".
If the class in the specified path for these attributes does not exist or empty, then the corresponding warning will be displayed
Inspection for the class inside the main "type" tag was done in the issue #582
Fixed Issues (if relevant)
Contribution checklist (*)