Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

879 enhance new UI form dialog ux #892

Merged
merged 14 commits into from
Dec 23, 2021
Merged

879 enhance new UI form dialog ux #892

merged 14 commits into from
Dec 23, 2021

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)

Enhanced error outputting for the new Magento 2 UI Form generation.

Screenshot 2021-12-23 at 10 57 09

Screenshot 2021-12-23 at 10 57 05

Fixed Issues (if relevant)

  1. Fixes Enhance errors showing for the new Magento 2 UI Component Form dialog window #879

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk linked an issue Dec 23, 2021 that may be closed by this pull request
Enhance errors showing for the new Magento 2 UI Component Form dialog window #879
Closed
andrewbess
andrewbess approved these changes Dec 23, 2021
View reviewed changes
Copy link
Collaborator

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bohdan-harniuk
Thank you for your contribution
Approved ✔️

@andrewbess andrewbess merged commit dc4b87d into magento:4.2.2-develop Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

@eduard13 eduard13 Awaiting requested review from eduard13

Assignees

@andrewbess andrewbess

@eduard13 eduard13

Labels
Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance errors showing for the new Magento 2 UI Component Form dialog window
3 participants
@bohdan-harniuk @andrewbess @eduard13