Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

913: Fixed parse usage #928

Merged
merged 2 commits into from
Jan 21, 2022
Merged

913: Fixed parse usage #928

merged 2 commits into from
Jan 21, 2022

Conversation

Iamwade
Copy link
Collaborator

@Iamwade Iamwade commented Jan 21, 2022

Description (*)
Fixed usage of deplicated and file upload

  1. Fixes Eliminate com.google.gson.JsonParser#parse usage #913

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk self-requested a review January 21, 2022 11:17
@bohdan-harniuk bohdan-harniuk self-assigned this Jan 21, 2022
@bohdan-harniuk bohdan-harniuk linked an issue Jan 21, 2022 that may be closed by this pull request
Eliminate com.google.gson.JsonParser#parse usage #913
Closed
bohdan-harniuk
bohdan-harniuk previously approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Iamwade!

Thank you for your contribution.

@bohdan-harniuk bohdan-harniuk self-requested a review January 21, 2022 12:27
bohdan-harniuk
bohdan-harniuk approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Iamwade, for test fixing.

@bohdan-harniuk bohdan-harniuk merged commit f0aeba6 into magento:4.2.2-develop Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bohdan-harniuk bohdan-harniuk bohdan-harniuk approved these changes

Assignees

@bohdan-harniuk bohdan-harniuk

Labels
Award: bug fix Award: category of expertise Award: test coverage Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate com.google.gson.JsonParser#parse usage
2 participants
@Iamwade @bohdan-harniuk