-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
966 add a placeholders to create new controller form #962
966 add a placeholders to create new controller form #962
Conversation
Still not sure exactly what is being asked for in these: is Controller Name supposed to be something along the lines of catalog/product/view? |
Hello, @lfolco! Yes, controller name for the provided path Regards, |
After testing it locally, I think the labels should be Unless the plugin has been changed, it doesn't look like it's doing anything along the lines of Also, it doesn't create a proper namespace. When I fill it in like this: I get a class with a namespace like this: What exactly is |
@lfolco, you have outdated plugin version. Please, update it and try it again. Everything should works fine with namespaces. Regards, |
20ec0ec
to
24490f3
Compare
@lfolco Hello! I think you are right. I changed labels and placeholders. Our goal is to make controller creation more understandable for everyone. Please, check new variants. Thanks! |
Hello, @SilinMykola, @lfolco! I think you made great improvements here! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
This looks great, thank you! |
Description (*)
I added the placeholders to the 'Create new Controller' form.
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)