Replace filter_var to make the intention of the code clearer

magento · Nov 2, 2016 · 1bbcff4 · 1bbcff4
1 parent ed946c0
commit 1bbcff4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/code/Magento/Catalog/Model/Product/Image.php b/app/code/Magento/Catalog/Model/Product/Image.php
@@ -278,7 +278,7 @@ public function getQuality()
      */
     public function setKeepAspectRatio($keep)
     {
-        $this->_keepAspectRatio = filter_var($keep, FILTER_VALIDATE_BOOLEAN);
+        $this->_keepAspectRatio = $keep && $keep !== 'false';
         return $this;
     }
 
@@ -288,7 +288,7 @@ public function setKeepAspectRatio($keep)
      */
     public function setKeepFrame($keep)
     {
-        $this->_keepFrame = filter_var($keep, FILTER_VALIDATE_BOOLEAN);
+        $this->_keepFrame = $keep && $keep !== 'false';
         return $this;
     }
 
@@ -298,7 +298,7 @@ public function setKeepFrame($keep)
      */
     public function setKeepTransparency($keep)
     {
-        $this->_keepTransparency = filter_var($keep, FILTER_VALIDATE_BOOLEAN);
+        $this->_keepTransparency = $keep && $keep !== 'false';
         return $this;
     }
 
@@ -308,7 +308,7 @@ public function setKeepTransparency($keep)
      */
     public function setConstrainOnly($flag)
     {
-        $this->_constrainOnly = filter_var($flag, FILTER_VALIDATE_BOOLEAN);
+        $this->_constrainOnly = $flag && $flag !== 'false';
         return $this;
     }