Merge pull request #648 from magento-sparta/SUPEE-7016

SUPEE-7016: Newsletter subscribers filter for firstname/lastname dosn't work.
magento · Sep 29, 2015 · 2e1580f · 2e1580f
2 parents 73227df + c343343
commit 2e1580f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 15 deletions.
diff --git a/app/code/Magento/Newsletter/Model/Resource/Subscriber/Collection.php b/app/code/Magento/Newsletter/Model/Resource/Subscriber/Collection.php
@@ -146,11 +146,7 @@ public function showCustomerInfo()
             [
                 'customer' => $this->getTable('customer_entity')
             ],
-            'main_table.customer_id = customer.entity_id',
-            [
-                'customer_lastname' => 'lastname',
-                'customer_firstname' => 'firstname'
-            ]
+            'main_table.customer_id = customer.entity_id'
         );
         return $this;
     }

diff --git a/app/code/Magento/Newsletter/Model/Subscriber.php b/app/code/Magento/Newsletter/Model/Subscriber.php
@@ -789,8 +789,8 @@ public function sendUnsubscriptionEmail()
     public function getSubscriberFullName()
     {
         $name = null;
-        if ($this->hasCustomerFirstname() || $this->hasCustomerLastname()) {
-            $name = $this->getCustomerFirstname() . ' ' . $this->getCustomerLastname();
+        if ($this->hasFirstname() || $this->hasLastname()) {
+            $name = $this->getFirstname() . ' ' . $this->getLastname();
         }
         return $name;
     }

diff --git a/app/code/Magento/Newsletter/Test/Unit/Model/SubscriberTest.php b/app/code/Magento/Newsletter/Test/Unit/Model/SubscriberTest.php
@@ -279,8 +279,8 @@ public function testUnsubscribeException()
 
     public function testGetSubscriberFullName()
     {
-        $this->subscriber->setCustomerFirstname('John');
-        $this->subscriber->setCustomerLastname('Doe');
+        $this->subscriber->setFirstname('John');
+        $this->subscriber->setLastname('Doe');
 
         $this->assertEquals('John Doe', $this->subscriber->getSubscriberFullName());
     }

diff --git a/app/code/Magento/Newsletter/view/adminhtml/layout/newsletter_subscriber_block.xml b/app/code/Magento/Newsletter/view/adminhtml/layout/newsletter_subscriber_block.xml
@@ -89,7 +89,7 @@
                     <block class="Magento\Backend\Block\Widget\Grid\Column" as="firstname">
                         <arguments>
                             <argument name="header" xsi:type="string" translate="true">Customer First Name</argument>
-                            <argument name="index" xsi:type="string">customer_firstname</argument>
+                            <argument name="index" xsi:type="string">firstname</argument>
                             <argument name="default" xsi:type="string">----</argument>
                             <argument name="header_css_class" xsi:type="string">col-first-name</argument>
                             <argument name="column_css_class" xsi:type="string">col-first-name</argument>
@@ -98,7 +98,7 @@
                     <block class="Magento\Backend\Block\Widget\Grid\Column" as="lastname">
                         <arguments>
                             <argument name="header" xsi:type="string" translate="true">Customer Last Name</argument>
-                            <argument name="index" xsi:type="string">customer_lastname</argument>
+                            <argument name="index" xsi:type="string">lastname</argument>
                             <argument name="default" xsi:type="string">----</argument>
                             <argument name="header_css_class" xsi:type="string">col-last-name</argument>
                             <argument name="column_css_class" xsi:type="string">col-last-name</argument>

diff --git a/...sts/integration/testsuite/Magento/Newsletter/Model/Resource/Subscriber/CollectionTest.php b/...sts/integration/testsuite/Magento/Newsletter/Model/Resource/Subscriber/CollectionTest.php
@@ -30,10 +30,10 @@ public function testShowCustomerInfo()
         $subscribers = $this->_collectionModel->getItems();
         $this->assertCount(2, $subscribers);
         $subscriber = array_shift($subscribers);
-        $this->assertEquals('John', $subscriber->getCustomerFirstname(), $subscriber->getSubscriberEmail());
-        $this->assertEquals('Smith', $subscriber->getCustomerLastname(), $subscriber->getSubscriberEmail());
+        $this->assertEquals('John', $subscriber->getFirstname(), $subscriber->getSubscriberEmail());
+        $this->assertEquals('Smith', $subscriber->getLastname(), $subscriber->getSubscriberEmail());
         $subscriber = array_shift($subscribers);
-        $this->assertNull($subscriber->getCustomerFirstname(), $subscriber->getSubscriberEmail());
-        $this->assertNull($subscriber->getCustomerLastname(), $subscriber->getSubscriberEmail());
+        $this->assertNull($subscriber->getFirstname(), $subscriber->getSubscriberEmail());
+        $this->assertNull($subscriber->getLastname(), $subscriber->getSubscriberEmail());
     }
 }