🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests: - #13374: Edited doc block of the walk method in a Collection (by @ByteCreation) - #13303: Remove redundant code for clarity (by @akiojalehto)
magento · Jan 31, 2018 · 3c6f5b0 · 3c6f5b0
2 parents 8c705bf + 4591b7b
commit 3c6f5b0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/app/code/Magento/AdminNotification/Model/Feed.php b/app/code/Magento/AdminNotification/Model/Feed.php
@@ -214,9 +214,6 @@ public function getFeedData()
         );
         $curl->write(\Zend_Http_Client::GET, $this->getFeedUrl(), '1.0');
         $data = $curl->read();
-        if ($data === false) {
-            return false;
-        }
         $data = preg_split('/^\r?$/m', $data, 2);
         $data = trim($data[1]);
         $curl->close();

diff --git a/lib/internal/Magento/Framework/Data/Collection.php b/lib/internal/Magento/Framework/Data/Collection.php
@@ -492,7 +492,7 @@ public function clear()
      *
      * Returns array with results of callback for each item
      *
-     * @param string $callback
+     * @param callable $callback
      * @param array $args
      * @return array
      */