Skip to content

Commit

Permalink
Merge branch 'ACP2E-1602' of https://github.com/magento-l3/magento2ce
Browse files Browse the repository at this point in the history
…into PR-02142023
  • Loading branch information
chittima committed Feb 15, 2023
2 parents 993e00c + 76b0758 commit 4b5c1dc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions app/code/Magento/Theme/Block/Html/Header.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public function getWelcome()
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
}
$this->_data['welcome'] = $this->escaper->escapeQuote($this->_data['welcome'], true);
return __($this->_data['welcome']);
return $this->escaper->escapeQuote(__($this->_data['welcome'])->render(), true);
}
}
8 changes: 4 additions & 4 deletions app/code/Magento/Theme/Test/Unit/Block/Html/HeaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ public function testGetWelcomeDefault()
{
$this->scopeConfig->expects($this->once())->method('getValue')
->with('design/header/welcome', ScopeInterface::SCOPE_STORE)
->willReturn('Welcome Message');
->willReturn("Message d'accueil par défaut");

$this->escaper->expects($this->once())
->method('escapeQuote')
->with('Welcome Message', true)
->willReturn('Welcome Message');
->with("Message d'accueil par défaut", true)
->willReturn("Message d\'accueil par défaut");

$this->assertEquals('Welcome Message', $this->unit->getWelcome());
$this->assertEquals("Message d\'accueil par défaut", $this->unit->getWelcome());
}
}

0 comments on commit 4b5c1dc

Please sign in to comment.