Skip to content

Commit

Permalink
Merge branch 'jquery-upgrade' of github.com:magento-lynx/magento2ce i…
Browse files Browse the repository at this point in the history
…nto MC-42049_fix_keydown_and_keyup
  • Loading branch information
eliseacornejo committed May 25, 2021
2 parents dc9ff50 + cc47e01 commit 86b6db8
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ define([
}

if (this.options.isRegionRequired) {
regionList.addClass('required-entry').removeAttr('disabled');
regionList.addClass('required-entry').prop('disabled', false);
container.addClass('required').show();
} else {
regionList.removeClass('required-entry validate-select').removeAttr('data-validate');
Expand All @@ -202,7 +202,7 @@ define([
regionList.hide();
container.hide();
} else {
regionList.removeAttr('disabled').show();
regionList.prop('disabled', false).show();
}
}

Expand All @@ -213,7 +213,7 @@ define([
this._removeSelectOptions(regionList);

if (this.options.isRegionRequired) {
regionInput.addClass('required-entry').removeAttr('disabled');
regionInput.addClass('required-entry').prop('disabled', false);
container.addClass('required').show();
} else {
if (!this.options.optionalRegionAllowed) { //eslint-disable-line max-depth
Expand All @@ -238,7 +238,7 @@ define([

// Add defaultvalue attribute to state/province select element
regionList.attr('defaultvalue', this.options.defaultRegion);
this.options.form.find('[type="submit"]').removeAttr('disabled').show();
this.options.form.find('[type="submit"]').prop('disabled', false).show();
},

/**
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Eav/view/adminhtml/web/js/input-types.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ define([
// Check current type (allow only compatible types)
if (~enabledTypes.indexOf(currentValue)) {
// Enable select and keep only available options (all other will be removed)
select.removeAttr('disabled').find('option').each(removeOption);
select.prop('disabled', false).find('option').each(removeOption);
// Add warning on page and event for show/hide it
select.after(warning).on('change', toggleWarning);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ define([
}

this.selectedFolder(folderId);
$(this.deleteButtonSelector).removeAttr('disabled').removeClass('disabled');
$(this.deleteButtonSelector).prop('disabled', false).removeClass('disabled');
}
});
});
2 changes: 1 addition & 1 deletion app/code/Magento/Paypal/view/adminhtml/web/js/rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ define([
var solutionConfiguration = solution.find(buttonConfiguration);

unlock || typeof unlock === 'undefined' ?
solutionConfiguration.removeClass('disabled').removeAttr('disabled') :
solutionConfiguration.removeClass('disabled').prop('disabled', false) :
solutionConfiguration.addClass('disabled').attr('disabled', 'disabled');
},

Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Paypal/view/adminhtml/web/js/solutions.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ define([
*/
wipeButtonsConfiguration: function () {
$(this.buttonConfiguration).removeClass('disabled')
.removeAttr('disabled');
.prop('disabled', false);
},

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,12 @@ define([
},

/**
* @param {Object} el
* @param {jQuery} el
* @this {swatchProductAttributes}
*/
_enable: function (el) {
if (!el.attr('readonly')) {
el.removeAttr('disabled');
el.prop('disabled', false);
}
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,9 @@ define([
* @private
*/
_Rewind: function (controls) {
controls.find('div[data-option-id], option[data-option-id]').removeClass('disabled').removeAttr('disabled');
controls.find('div[data-option-id], option[data-option-id]')
.removeClass('disabled')
.prop('disabled', false);
controls.find('div[data-option-empty], option[data-option-empty]')
.attr('disabled', true)
.addClass('disabled')
Expand Down

0 comments on commit 86b6db8

Please sign in to comment.