Skip to content

Commit

Permalink
0.1.0-alpha93
Browse files Browse the repository at this point in the history
* Price template refactoring
   * Refactored order item templates in the Sales, Bundle and Downloadable modules
   * Eliminated the unused PHTML templates and removed the direct dependencies on the TaxHelper module in the Catalog module
 * Service layer implementation:
   * Created service layer for Order creation
   * Created service layer for Invoice
   * Created service layer for Credit Memo
   * Created service layer for Shipment
 * Introduce the Search library:
   * Created adapter interfaces for the Search library
   * Created response structure
   * Created parsing of XML declaration and creation of library objects (Queries, Filters, Aggregations)
 * Refactored Framework\Stdlib\Cookie to use CookieManager
 * Added the ability to prevent the backend cookie from going to the storefront
 * Fixed bugs:
   * Fixed an issue where taxes  were  not added in some orders
   * Fixed an issue were the Add New Address button did not work if the default address was already set
   * Fixed a Google Chrome and Internet Explorer specific issue when a JavaScript error made it impossible to register   during checkout downloadable product
   * Fixed an issue when the credit card iframe (PayPal or 3D secure)  was absent on the Order Review step during Onepage Checkout
   * Fixed an issue with the   Tax Rate, Customer Tax Class and Product Tax Class multiselects on the Tax Rule Information page
   * Fixed JavaScript issues which prevented saving a newsletter template.
   * Modified the Button component behavior
   * Fixed an issue where it was impossible for a guest customer to register during Onepage checkout when the Require Customer To Be Logged In To Checkout option was set to Yes
   * Fixed an issue where the Calendar icons were not displayed on the storefront
   * Fixed an  AJAX loader issue in the Admin panel
   * Fixed an issue where it was impossible to upload images for  variations of a configurable product on product form
   * Fixed an issue where clicking on a row in the Search Terms Report Grid leads to 404 page
   * Fixed an issue where configurable products fixture creates out of stock products
   * Fixed an issue where Magento crashed when invalid cookie domain was set
   * Fixed an issue where the Change checkbox label overlapped the text message for a recurring profile attribute on the attribute mass update page
   * Fixed an issue where integrity test determined normal dependencies as redundant
   * Fixed an issue where Catalog\Service\V1\Product\Attribute\ReadService::search returned an error
   * Fixed an issue where Magento\Catalog\Service\V1\Category\Attribute\ReadService::options returned empty results
 * GitHub requests:
  * [#160] (https://github.com/magento/bugathon_march_2013/issues/160) -- Wrong default value for memory_limit in .htaccess.sample
  * [#480] (#480) -- Provide instructions on adding memcache support for Magento 2
  * [#612] (#612) -- Category Layered Navigation : Selection of disabled entity
  * [#626] (#626) -- Unable to install under IIS / FastCGI
  • Loading branch information
magento-team committed Sep 1, 2014
1 parent 906c3c7 commit a2ea67f
Show file tree
Hide file tree
Showing 829 changed files with 37,808 additions and 9,866 deletions.
2 changes: 1 addition & 1 deletion .htaccess.sample
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
############################################
## adjust memory limit

php_value memory_limit 128M
php_value memory_limit 256M
php_value max_execution_time 18000

############################################
Expand Down
45 changes: 43 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,44 @@
0.1.0-alpha93
=============
* Price template refactoring
* Refactored order item templates in the Sales, Bundle and Downloadable modules
* Eliminated the unused PHTML templates and removed the direct dependencies on the TaxHelper module in the Catalog module
* Service layer implementation:
* Created service layer for Order creation
* Created service layer for Invoice
* Created service layer for Credit Memo
* Created service layer for Shipment
* Introduce the Search library:
* Created adapter interfaces for the Search library
* Created response structure
* Created parsing of XML declaration and creation of library objects (Queries, Filters, Aggregations)
* Refactored Framework\Stdlib\Cookie to use CookieManager
* Added the ability to prevent the backend cookie from going to the storefront
* Fixed bugs:
* Fixed an issue where taxes were not added in some orders
* Fixed an issue were the Add New Address button did not work if the default address was already set
* Fixed a Google Chrome and Internet Explorer specific issue when a JavaScript error made it impossible to register during checkout downloadable product
* Fixed an issue when the credit card iframe (PayPal or 3D secure) was absent on the Order Review step during Onepage Checkout
* Fixed an issue with the Tax Rate, Customer Tax Class and Product Tax Class multiselects on the Tax Rule Information page
* Fixed JavaScript issues which prevented saving a newsletter template.
* Modified the Button component behavior
* Fixed an issue where it was impossible for a guest customer to register during Onepage checkout when the Require Customer To Be Logged In To Checkout option was set to Yes
* Fixed an issue where the Calendar icons were not displayed on the storefront
* Fixed an AJAX loader issue in the Admin panel
* Fixed an issue where it was impossible to upload images for variations of a configurable product on product form
* Fixed an issue where clicking on a row in the Search Terms Report Grid leads to 404 page
* Fixed an issue where configurable products fixture creates out of stock products
* Fixed an issue where Magento crashed when invalid cookie domain was set
* Fixed an issue where the Change checkbox label overlapped the text message for a recurring profile attribute on the attribute mass update page
* Fixed an issue where integrity test determined normal dependencies as redundant
* Fixed an issue where Catalog\Service\V1\Product\Attribute\ReadService::search returned an error
* Fixed an issue where Magento\Catalog\Service\V1\Category\Attribute\ReadService::options returned empty results
* GitHub requests:
* [#160] (https://github.com/magento/bugathon_march_2013/issues/160) -- Wrong default value for memory_limit in .htaccess.sample
* [#480] (https://github.com/magento/magento2/pull/480) -- Provide instructions on adding memcache support for Magento 2
* [#612] (https://github.com/magento/magento2/issues/612) -- Category Layered Navigation : Selection of disabled entity
* [#626] (https://github.com/magento/magento2/issues/626) -- Unable to install under IIS / FastCGI

0.1.0-alpha92
=============
* Implemented API services:
Expand All @@ -10,7 +51,7 @@
* Framework Improvements:
* Ability to drop/regenerate access for native mobile apps
* Ability to support extensible service data objects
* No Code Duplication in Root Templates (MAGETWO-26278)
* No Code Duplication in Root Templates
* Fixed bugs:
* Persistance session application. Loggin out the customer
* Placing the order with two terms and conditions
Expand All @@ -20,7 +61,7 @@
* Validation for country_id/region_id and percentage_rate during Tax Rate creation
* Declaration of getSortOrders in Magento\Framework\Service\V1\Data\SearchCriteria
* Order cancellation for online payment methods
* Order online processing for Authorize.net Direct Post
* Order online processing for Authorize.net Direct Post
* Backend grids while search
* Adding of downlodable sample block on product page
* Variations on duplicated configurable product
Expand Down
12 changes: 6 additions & 6 deletions app/code/Magento/AdminNotification/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
"magento/module-store": "0.1.0-alpha92",
"magento/module-core": "0.1.0-alpha92",
"magento/module-backend": "0.1.0-alpha92",
"magento/module-theme": "0.1.0-alpha92",
"magento/framework": "0.1.0-alpha92",
"magento/module-store": "0.1.0-alpha93",
"magento/module-core": "0.1.0-alpha93",
"magento/module-backend": "0.1.0-alpha93",
"magento/module-theme": "0.1.0-alpha93",
"magento/framework": "0.1.0-alpha93",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
"version": "0.1.0-alpha92",
"version": "0.1.0-alpha93",
"extra": {
"map": [
[
Expand Down
6 changes: 3 additions & 3 deletions app/code/Magento/Authorization/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
"description": "Authorization module provides access to Magento ACL functionality.",
"require": {
"php": "~5.4.11|~5.5.0",
"magento/module-backend": "0.1.0-alpha92",
"magento/framework": "0.1.0-alpha92",
"magento/module-backend": "0.1.0-alpha93",
"magento/framework": "0.1.0-alpha93",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
"version": "0.1.0-alpha92",
"version": "0.1.0-alpha93",
"extra": {
"map": [
[
Expand Down
15 changes: 14 additions & 1 deletion app/code/Magento/Authorizenet/Model/Directpost/Session.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ class Session extends \Magento\Framework\Session\SessionManager
* @param \Magento\Framework\Session\SaveHandlerInterface $saveHandler
* @param \Magento\Framework\Session\ValidatorInterface $validator
* @param \Magento\Framework\Session\StorageInterface $storage
* @param \Magento\Framework\Stdlib\CookieManager $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @param string|null $sessionName
* @internal param array $data
*/
Expand All @@ -45,9 +47,20 @@ public function __construct(
\Magento\Framework\Session\SaveHandlerInterface $saveHandler,
\Magento\Framework\Session\ValidatorInterface $validator,
\Magento\Framework\Session\StorageInterface $storage,
\Magento\Framework\Stdlib\CookieManager $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory,
$sessionName = null
) {
parent::__construct($request, $sidResolver, $sessionConfig, $saveHandler, $validator, $storage);
parent::__construct(
$request,
$sidResolver,
$sessionConfig,
$saveHandler,
$validator,
$storage,
$cookieManager,
$cookieMetadataFactory
);
$this->start($sessionName);
}

Expand Down
20 changes: 10 additions & 10 deletions app/code/Magento/Authorizenet/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
"magento/module-store": "0.1.0-alpha92",
"magento/module-sales": "0.1.0-alpha92",
"magento/module-checkout": "0.1.0-alpha92",
"magento/module-backend": "0.1.0-alpha92",
"magento/module-core": "0.1.0-alpha92",
"magento/module-payment": "0.1.0-alpha92",
"magento/module-centinel": "0.1.0-alpha92",
"magento/module-catalog": "0.1.0-alpha92",
"magento/framework": "0.1.0-alpha92",
"magento/module-store": "0.1.0-alpha93",
"magento/module-sales": "0.1.0-alpha93",
"magento/module-checkout": "0.1.0-alpha93",
"magento/module-backend": "0.1.0-alpha93",
"magento/module-core": "0.1.0-alpha93",
"magento/module-payment": "0.1.0-alpha93",
"magento/module-centinel": "0.1.0-alpha93",
"magento/module-catalog": "0.1.0-alpha93",
"magento/framework": "0.1.0-alpha93",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
"version": "0.1.0-alpha92",
"version": "0.1.0-alpha93",
"extra": {
"map": [
[
Expand Down
111 changes: 111 additions & 0 deletions app/code/Magento/Backend/AdminConfig.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
<?php
/**
* Backend Session configuration object
*
* Magento
*
* NOTICE OF LICENSE
*
* This source file is subject to the Open Software License (OSL 3.0)
* that is bundled with this package in the file LICENSE.txt.
* It is also available through the world-wide-web at this URL:
* http://opensource.org/licenses/osl-3.0.php
* If you did not receive a copy of the license and are unable to
* obtain it through the world-wide-web, please send an email
* to license@magentocommerce.com so we can send you a copy immediately.
*
* DISCLAIMER
*
* Do not edit or add to this file if you wish to upgrade Magento to newer
* versions in the future. If you wish to customize Magento for your
* needs please refer to http://www.magentocommerce.com for more information.
*
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
namespace Magento\Backend;

use Magento\Backend\App\Area\FrontNameResolver;
use Magento\Framework\Session\Config;

/**
* Magento Backend session configuration
*
* @method Config setSaveHandler()
*/
class AdminConfig extends Config
{
/**
* @var FrontNameResolver $frontNameResolver
*/
protected $frontNameResolver;

/**
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param \Magento\Framework\Stdlib\String $stringHelper
* @param \Magento\Framework\App\RequestInterface $request
* @param \Magento\Framework\App\State $appState
* @param \Magento\Framework\App\Filesystem $filesystem
* @param string $scopeType
* @param FrontNameResolver $frontNameResolver
* @param string $saveMethod
* @param null|string $savePath
* @param null|string $cacheLimiter
* @param string $lifetimePath
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function __construct(
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
\Magento\Framework\Stdlib\String $stringHelper,
\Magento\Framework\App\RequestInterface $request,
\Magento\Framework\App\State $appState,
\Magento\Framework\App\Filesystem $filesystem,
$scopeType,
FrontNameResolver $frontNameResolver,
$saveMethod = \Magento\Framework\Session\SaveHandlerInterface::DEFAULT_HANDLER,
$savePath = null,
$cacheLimiter = null,
$lifetimePath = self::XML_PATH_COOKIE_LIFETIME
) {
parent::__construct(
$scopeConfig,
$stringHelper,
$request,
$appState,
$filesystem,
$scopeType,
$saveMethod,
$savePath,
$cacheLimiter,
$lifetimePath
);

$this->frontNameResolver = $frontNameResolver;

$baseUrl = $this->_httpRequest->getBaseUrl();
$adminPath = $this->extractAdminPath($baseUrl);
$this->setCookiePath($adminPath);
}

/**
* Determine the admin path
*
* @param string $baseUrl
* @return string
* @throws \InvalidArgumentException
*/
private function extractAdminPath($baseUrl)
{
if (!is_string($baseUrl)) {
throw new \InvalidArgumentException('Cookie path is not a string.');
}

$adminPath = $this->frontNameResolver->getFrontName();

if (!substr($baseUrl, -1) || ('/' != substr($baseUrl, -1))) {
$baseUrl = $baseUrl . '/';
}

return $baseUrl . $adminPath;
}
}
50 changes: 28 additions & 22 deletions app/code/Magento/Backend/Model/Auth/Session.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
*/
namespace Magento\Backend\Model\Auth;

use \Magento\Framework\Stdlib\CookieManager;
use \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;

/**
* Backend Auth session model
*
Expand All @@ -44,7 +47,7 @@ class Session extends \Magento\Framework\Session\SessionManager implements \Mage
const XML_PATH_SESSION_LIFETIME = 'admin/security/session_lifetime';

/**
* Whether it is the first page after successfull login
* Whether it is the first page after successful login
*
* @var boolean
*/
Expand All @@ -67,22 +70,18 @@ class Session extends \Magento\Framework\Session\SessionManager implements \Mage
*/
protected $_config;

/**
* @var \Magento\Framework\Stdlib\Cookie
*/
protected $_cookie;

/**
* @param \Magento\Framework\App\Request\Http $request
* @param \Magento\Framework\Session\SidResolverInterface $sidResolver
* @param \Magento\Framework\Session\Config\ConfigInterface $sessionConfig
* @param \Magento\Framework\Session\SaveHandlerInterface $saveHandler
* @param \Magento\Framework\Session\ValidatorInterface $validator
* @param \Magento\Framework\Session\StorageInterface $storage
* @param CookieManager $cookieManager
* @param CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Framework\Acl\Builder $aclBuilder
* @param \Magento\Backend\Model\UrlInterface $backendUrl
* @param \Magento\Backend\App\ConfigInterface $config
* @param \Magento\Framework\Stdlib\Cookie $cookie
*/
public function __construct(
\Magento\Framework\App\Request\Http $request,
Expand All @@ -91,16 +90,25 @@ public function __construct(
\Magento\Framework\Session\SaveHandlerInterface $saveHandler,
\Magento\Framework\Session\ValidatorInterface $validator,
\Magento\Framework\Session\StorageInterface $storage,
CookieManager $cookieManager,
CookieMetadataFactory $cookieMetadataFactory,
\Magento\Framework\Acl\Builder $aclBuilder,
\Magento\Backend\Model\UrlInterface $backendUrl,
\Magento\Backend\App\ConfigInterface $config,
\Magento\Framework\Stdlib\Cookie $cookie
\Magento\Backend\App\ConfigInterface $config
) {
$this->_config = $config;
$this->_aclBuilder = $aclBuilder;
$this->_backendUrl = $backendUrl;
$this->_cookie = $cookie;
parent::__construct($request, $sidResolver, $sessionConfig, $saveHandler, $validator, $storage);
parent::__construct(
$request,
$sidResolver,
$sessionConfig,
$saveHandler,
$validator,
$storage,
$cookieManager,
$cookieMetadataFactory
);
$this->start();
}

Expand Down Expand Up @@ -187,22 +195,20 @@ public function prolong()
$currentTime = time();

$this->setUpdatedAt($currentTime);
$cookieValue = $this->_cookie->get($this->getName());
$cookieValue = $this->cookieManager->getCookie($this->getName());
if ($cookieValue) {
$this->_cookie->set(
$this->getName(),
$cookieValue,
$lifetime,
$this->sessionConfig->getCookiePath(),
$this->sessionConfig->getCookieDomain(),
$this->sessionConfig->getCookieSecure(),
$this->sessionConfig->getCookieHttpOnly()
);
$cookieMetadata = $this->cookieMetadataFactory->createPublicCookieMetadata()
->setDuration($lifetime)
->setPath($this->sessionConfig->getCookiePath())
->setDomain($this->sessionConfig->getCookieDomain())
->setSecure($this->sessionConfig->getCookieSecure())
->setHttpOnly($this->sessionConfig->getCookieHttpOnly());
$this->cookieManager->setPublicCookie($this->getName(), $cookieValue, $cookieMetadata);
}
}

/**
* Check if it is the first page after successfull login
* Check if it is the first page after successful login
*
* @return bool
*/
Expand Down
Loading

0 comments on commit a2ea67f

Please sign in to comment.