Skip to content

Commit

Permalink
Patch to allow multiple filter_url_params to function
Browse files Browse the repository at this point in the history
Multiple filter_url_params in UI_component will fail due to missing / separator in sprintf function.

Otherwise the 2nd url parameter will be compiled into the value of the first parameter such as SKU/12345pr/
when in fact the second variable passed was PR/PULLREQUEST/ as part of SKU/12345/pr/PULLREQUEST!

Only happens when you pass multiple variables to in ui_component such as 
`           <argument name="data" xsi:type="array">
                <item name="config" xsi:type="array">
             <item name="update_url" xsi:type="url"   path="mui/index/render"/>
        <item name="filter_url_params" xsi:type="array">
          <item name="customer_number" xsi:type="string">*</item>
         <item name="sku" xsi:type="string">*</item>
        </item>

                </item>
            </argument>
  `
  • Loading branch information
southerncomputer authored May 21, 2017
1 parent bdb0464 commit ca543eb
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ protected function prepareUpdateUrl()
}
if ($paramValue) {
$this->data['config']['update_url'] = sprintf(
'%s%s/%s',
'%s%s/%s/',
$this->data['config']['update_url'],
$paramName,
$paramValue
Expand Down

0 comments on commit ca543eb

Please sign in to comment.