ENGCOM-4356: Removed unused else block and corrected return types #21405

magento · Feb 28, 2019 · cd75c92 · cd75c92
2 parents 2ec994e + a0bba02
commit cd75c92
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/app/code/Magento/Fedex/Model/Carrier.php b/app/code/Magento/Fedex/Model/Carrier.php
@@ -363,7 +363,6 @@ public function setRequest(RateRequest $request)
 
         if ($request->getDestPostcode()) {
             $r->setDestPostal($request->getDestPostcode());
-        } else {
         }
 
         if ($request->getDestCity()) {

diff --git a/app/code/Magento/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php b/app/code/Magento/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php
@@ -171,7 +171,7 @@ public function getMessage()
     /**
      * Retrieve save url
      *
-     * @return array
+     * @return string
      * @codeCoverageIgnore
      */
     public function getSaveUrl()

diff --git a/app/code/Magento/GiftMessage/Block/Cart/GiftOptions.php b/app/code/Magento/GiftMessage/Block/Cart/GiftOptions.php
@@ -3,13 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\GiftMessage\Block\Cart;
 
 use Magento\Backend\Block\Template\Context;
 use Magento\Framework\Json\Encoder;
 use Magento\GiftMessage\Model\CompositeConfigProvider;
 
 /**
+ * Gift options cart block.
+ *
  * @api
  * @since 100.0.2
  */
@@ -63,6 +66,8 @@ public function __construct(
     }
 
     /**
+     * Retrieve encoded js layout.
+     *
      * @return string
      */
     public function getJsLayout()
@@ -76,7 +81,7 @@ public function getJsLayout()
     /**
      * Retrieve gift message configuration
      *
-     * @return array
+     * @return string
      */
     public function getGiftOptionsConfigJson()
     {

diff --git a/app/code/Magento/GiftMessage/Model/Type/Plugin/Onepage.php b/app/code/Magento/GiftMessage/Model/Type/Plugin/Onepage.php
@@ -3,8 +3,12 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\GiftMessage\Model\Type\Plugin;
 
+/**
+ * Add gift message to quote plugin.
+ */
 class Onepage
 {
     /**
@@ -30,9 +34,11 @@ public function __construct(
     }
 
     /**
+     * Add gift message ot quote.
+     *
      * @param \Magento\Checkout\Model\Type\Onepage $subject
      * @param array $result
-     * @return $this
+     * @return array
      */
     public function afterSaveShippingMethod(
         \Magento\Checkout\Model\Type\Onepage $subject,