Skip to content

Commit

Permalink
Fix issue causing attribute not loading with getList
Browse files Browse the repository at this point in the history
As specified in issue #17759, CustomerRepository::getList() is
unexpectedly returning NULL, when CustomerRepository::get() is correctly
returning the value. Specifying the attribute as billing_company instead
of company removes the conflict.
  • Loading branch information
teganbold committed Dec 7, 2018
1 parent 3091634 commit d600179
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ public function getList(SearchCriteriaInterface $searchCriteria)
->joinAttribute('billing_telephone', 'customer_address/telephone', 'default_billing', null, 'left')
->joinAttribute('billing_region', 'customer_address/region', 'default_billing', null, 'left')
->joinAttribute('billing_country_id', 'customer_address/country_id', 'default_billing', null, 'left')
->joinAttribute('company', 'customer_address/company', 'default_billing', null, 'left');
->joinAttribute('billing_company', 'customer_address/company', 'default_billing', null, 'left');

$this->collectionProcessor->process($searchCriteria, $collection);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ public function testGetList()
->willReturnSelf();
$collection->expects($this->at(7))
->method('joinAttribute')
->with('company', 'customer_address/company', 'default_billing', null, 'left')
->with('billing_company', 'customer_address/company', 'default_billing', null, 'left')
->willReturnSelf();
$this->collectionProcessorMock->expects($this->once())
->method('process')
Expand Down

0 comments on commit d600179

Please sign in to comment.