Skip to content

Commit

Permalink
Misconfigured aria-labelledby for product tabs
Browse files Browse the repository at this point in the history
Good afternoon,

I find out attribute aria-labelledby is misconfigured.
It must be declared for the content of the tab and not the title, in particular, for a parent tag.

Ilan PARMENTIER

Source :
https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html#sc1_label
  • Loading branch information
Ilan Parmentier authored and amol2jcommerce committed Mar 1, 2019
1 parent 13b0fe9 commit e5676cf
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
$label = $block->getChildData($alias, 'title');
?>
<div class="data item title"
aria-labelledby="tab-label-<?= /* @escapeNotVerified */ $alias ?>-title"
data-role="collapsible" id="tab-label-<?= /* @escapeNotVerified */ $alias ?>">
<a class="data switch"
tabindex="-1"
Expand All @@ -31,7 +30,8 @@
<?= /* @escapeNotVerified */ $label ?>
</a>
</div>
<div class="data item content" id="<?= /* @escapeNotVerified */ $alias ?>" data-role="content">
<div class="data item content"
aria-labelledby="tab-label-<?= /* @escapeNotVerified */ $alias ?>-title" id="<?= /* @escapeNotVerified */ $alias ?>" data-role="content">
<?= /* @escapeNotVerified */ $html ?>
</div>
<?php endforeach;?>
Expand Down

0 comments on commit e5676cf

Please sign in to comment.