graphQl-784: added guest tests

magento · Jul 25, 2019 · e9b6334 · e9b6334
1 parent 28c5a88
commit e9b6334
Show file tree

Hide file tree

Showing 5 changed files with 49 additions and 63 deletions.
diff --git a/app/code/Magento/QuoteGraphQl/Model/Cart/QuoteAddressFactory.php b/app/code/Magento/QuoteGraphQl/Model/Cart/QuoteAddressFactory.php
@@ -61,7 +61,7 @@ public function __construct(
     public function createBasedOnInputData(array $addressInput): QuoteAddress
     {
         $addressInput['country_id'] = $addressInput['country_code'] ?? '';
-        if ($addressInput['country_id'] && !ctype_upper($addressInput['country_code'] )) {
+        if ($addressInput['country_id'] && !ctype_upper($addressInput['country_code'])) {
             throw new GraphQlInputException(
                 __('"Country Code" cannot contain lowercase characters.')
             );

diff --git a/...s/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php b/...s/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php
@@ -645,7 +645,7 @@ public function testSetNewBillingAddressWithRedundantStreetLine()
      * @expectedException \Exception
      * @expectedExceptionMessage "Country Code" cannot contain lowercase characters.
      */
-    public function testSetNewBillingAddressWithLowercaseCountryCode()
+    public function testSetBillingAddressWithLowerCaseCountry()
     {
         $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
 

diff --git a/.../api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetShippingAddressOnCartTest.php b/.../api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetShippingAddressOnCartTest.php
@@ -602,59 +602,6 @@ public function testSetShippingAddressToGuestCart()
         $this->graphQlMutation($query, [], '', $this->getHeaderMap());
     }
 
-    /**
-     * @magentoApiDataFixture Magento/Customer/_files/customer.php
-     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
-     * @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php
-     * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
-     */
-    public function testSetShippingAddressWithLowerCaseCountry()
-    {
-        $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
-
-        $query = <<<QUERY
-mutation {
-  setShippingAddressesOnCart(
-    input: {
-      cart_id: "{$maskedQuoteId}"
-      shipping_addresses: [
-        {
-          address: {
-            firstname: "John"
-            lastname: "Doe"
-            street: ["6161 West Centinella Avenue"]
-            city: "Culver City"
-            region: "CA"
-            postcode: "90230"
-            country_code: "us"
-            telephone: "555-555-55-55"
-          }
-        }
-      ]
-    }
-  ) {
-    cart {
-      shipping_addresses {
-        region {
-            code
-        }
-        country {
-            code
-        }
-      }
-    }
-  }
-}
-QUERY;
-        $result = $this->graphQlMutation($query, [], '', $this->getHeaderMap());
-
-        self::assertCount(1, $result['setShippingAddressesOnCart']['cart']['shipping_addresses']);
-        $address = reset($result['setShippingAddressesOnCart']['cart']['shipping_addresses']);
-
-        $this->assertEquals('US', $address['country']['code']);
-        $this->assertEquals('CA', $address['region']['code']);
-    }
-
     /**
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
      * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
@@ -663,7 +610,7 @@ public function testSetShippingAddressWithLowerCaseCountry()
      * @expectedException \Exception
      * @expectedExceptionMessage "Country Code" cannot contain lowercase characters.
      */
-    public function testSetNewShippingAddressOnCartWithLowercaseCountryCode()
+    public function testSetShippingAddressWithLowerCaseCountry()
     {
         $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
 

diff --git a/...ests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetBillingAddressOnCartTest.php b/...ests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetBillingAddressOnCartTest.php
@@ -455,6 +455,49 @@ public function testSetNewBillingAddressRedundantStreetLine()
         $this->graphQlMutation($query);
     }
 
+    /**
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
+     * @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
+     * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
+     * @expectedException \Exception
+     * @expectedExceptionMessage "Country Code" cannot contain lowercase characters.
+     */
+    public function testSetBillingAddressWithLowerCaseCountry()
+    {
+        $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
+
+        $query = <<<QUERY
+mutation {
+  setBillingAddressOnCart(
+    input: {
+      cart_id: "$maskedQuoteId"
+      billing_address: {
+         address: {
+          firstname: "test firstname"
+          lastname: "test lastname"
+          company: "test company"
+          street: ["test street 1", "test street 2"]
+          city: "test city"
+          region: "test region"
+          postcode: "887766"
+          country_code: "us"
+          telephone: "88776655"
+          save_in_address_book: false
+         }
+      }
+    }
+  ) {
+    cart {
+      billing_address {
+        firstname
+      }
+    }
+  }
+}
+QUERY;
+        $this->graphQlMutation($query);
+    }
+
     /**
      * Verify the all the whitelisted fields for a New Address Object
      *

diff --git a/...sts/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingAddressOnCartTest.php b/...sts/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingAddressOnCartTest.php
@@ -411,6 +411,8 @@ public function testSetShippingAddressOnNonExistentCart()
      * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
      * @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
      * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
+     * @expectedException \Exception
+     * @expectedExceptionMessage "Country Code" cannot contain lowercase characters.
      */
     public function testSetShippingAddressWithLowerCaseCountry()
     {
@@ -450,13 +452,7 @@ public function testSetShippingAddressWithLowerCaseCountry()
   }
 }
 QUERY;
-        $result = $this->graphQlMutation($query);
-
-        self::assertCount(1, $result['setShippingAddressesOnCart']['cart']['shipping_addresses']);
-        $address = reset($result['setShippingAddressesOnCart']['cart']['shipping_addresses']);
-
-        $this->assertEquals('US', $address['country']['code']);
-        $this->assertEquals('CA', $address['region']['code']);
+        $this->graphQlMutation($query);
     }
 
     /**