Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit Memo - Wrong tax calculation! #10982

Closed
andidhouse opened this issue Sep 21, 2017 · 7 comments
Closed

Credit Memo - Wrong tax calculation! #10982

andidhouse opened this issue Sep 21, 2017 · 7 comments
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@andidhouse
Copy link

Preconditions

  1. Magento 2.1.7 via download
  2. Nginx, php7, varnish, redis

Steps to reproduce

  1. Create tax class for product with 19%
  2. Create Shipping tax class with 19%
  3. Order a product with shipping costs
  4. create a credit memo of the product cost (with the shipping costs)

Expected result

  1. The credit memo (for the article only) includes just the tax for the product - not the shipping tax of course

Actual result

  1. The credit memo includes also the shipping tax which is totally wrong as the shipping costs where not refunded. Screens attached.

I think there are 10-20 tickets reported nearly close to this one - i am not shure why the magento team does not check all aspects of the credit memo to get rid of all bugs. Also this is worst case with payment methods like PayPal which refund the credit memo amount automatically - so this leads to serious problems in the accounting.

1
2

There is also a massive bug in the credit memo creation. The total amount does not change in the credit memo backend if you change the Adjustment Fee/ Refund at all - Using Safari for Mac. Could you pls also check this!

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 21, 2017
@andidhouse
Copy link
Author

This only happens sometimes - some refunds are ok - some have a calculation error.

I am also questioning why there are two ways to refund an order:

  1. Create a credit memo over the order page directly
  2. Create a credit memo over the invoice page

We realized this bugs only appeares on the credit creation when we do a credit memo over the invoice (which needs to be done to create an online refund).

Not shure why there are two ways?

@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 21, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 20, 2017
@magento-engcom-team
Copy link
Contributor

@andidhouse, thank you for your report.
We've created internal ticket(s) MAGETWO-82400 to track progress on the issue.

@ste88
Copy link

ste88 commented May 10, 2018

Hi,
we have reproduced the problem only with the "online" credit memo created from the invoice page.
Offline credit memo works correctly.

Hope it is useful.

@ottosschweiz
Copy link

Hello,

Has something happened since this issue was reported?
Or is there a known workaround to fix this problem?

It's just a really bad thing when those amounts are not correct on online credit memos.

Thank you

@vseager
Copy link
Contributor

vseager commented Oct 5, 2018

A year since this issue was raised and still no resolution or known workaround?!

@kanduvisla
Copy link
Contributor

We just encountered this issue today in a Magento 2.2.6 shop which has been recently updaten from Magento 2.1.15. The order was placed in 2.1, but the credit memo was created in 2.2 (due to the passing of time).

We are unable to reproduce this issue on our dev-setup. Also, I cannot seem to find how you can create a credit memo from the invoice page. Is this feature removed in Magento 2.2?

magento-engcom-team pushed a commit that referenced this issue Dec 11, 2018
- Added possibility to recalculate tax amounts in case of '0' shipping value refund
magento-engcom-team pushed a commit that referenced this issue Dec 11, 2018
magento-engcom-team pushed a commit that referenced this issue Dec 11, 2018
- Converting base order shipping amount for correct calculation;
magento-engcom-team pushed a commit that referenced this issue Dec 11, 2018
magento-engcom-team pushed a commit that referenced this issue Dec 11, 2018
magento-engcom-team pushed a commit that referenced this issue Dec 11, 2018
magento-engcom-team pushed a commit that referenced this issue Dec 11, 2018
Fixed issues:
MAGETWO-91526 [2.3] Authorize.net Direct Post does not show credit card information
MAGETWO-91769 Credit Memo - Wrong tax calculation! #10982
MAGETWO-91639 Tax is added despite customer group changes
@sdzhepa
Copy link
Contributor

sdzhepa commented Apr 30, 2019

Hello @andidhouse @ottosschweiz @vseager @kanduvisla

Thank you for contribution and collaboration!

The corresponding internal tickets MAGETWO-91769, MAGETWO-82400 were fixed and closed by Magento team

Delivered to 2.3-develop branch and should be available with 2.3.1 release
Please see details in the next commits:

Delivered to 2.2-develop branch and should be available with 2.2.8 release
Please see details in the next commits:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

8 participants