Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method "getChildren" sort ordering #11310

Closed
EliasKotlyar opened this issue Oct 9, 2017 · 5 comments
Closed

Method "getChildren" sort ordering #11310

EliasKotlyar opened this issue Oct 9, 2017 · 5 comments
Assignees
@denisristic
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@EliasKotlyar
Copy link
Contributor

Preconditions

Bug can be reproduced in every Magento Version. M1 has it, M2 has it. Even M2.2 has it.

Steps to reproduce

Create a Code which will call the following Class:
M1: Mage_Catalog_Model_Resource_Category_Flat
M2: Magento\Catalog\Model\ResourceModel\Category\Flat

With the following Method:
getChildren()

Expected result

You will get a list of Ids of the children categories.
This list is sorted by the "position" attribute.

Actual result

You will get a list of Ids of the Children Categories.
This list is sorted by entity-id attribute.

I dont see any special case where you would need the sorting by the entity_id. More usual you will need them sorted in the same order as in the Backend(by the position attribute).

Greetings,
Elias
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 9, 2017
@EliasKotlyar EliasKotlyar mentioned this issue Oct 9, 2017
Closed
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 9, 2017
@magento-engcom-team
Copy link
Contributor

@EliasKotlyar, thank you for your report.
We've created internal ticket(s) MAGETWO-81314 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 9, 2017
@denisristic
Copy link
Contributor

I'm working on it #SQUASHTOBERFEST

@denisristic denisristic mentioned this issue Oct 10, 2017
Merged
@denisristic
Copy link
Contributor

@ishakhsuvarov this ticket is resolved :)

@okorshenko
Copy link
Contributor

Hi @EliasKotlyar the issue has been fixed in 2.2-develop branch and will be available in 2.2.2 release soon

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 17, 2017
@magento magento deleted a comment from magento-team Nov 1, 2017
@magento-engcom-team
Copy link
Contributor

Hi @EliasKotlyar. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1283 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denisristic denisristic

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@denisristic @okorshenko @EliasKotlyar @magento-engcom-team