Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDED $sortByPostion flag to getChildren() #11342

Merged
merged 5 commits into from
Oct 16, 2017

Conversation

denisristic
Copy link
Contributor

@denisristic denisristic commented Oct 10, 2017

Method "getChildren" sort ordering (SQUASHTOBERFEST)

Description

ADDED $sortByPostion flag to getChildren()

Fixed Issues (if relevant)

  1. Method "getChildren" sort ordering #11310

@ishakhsuvarov
Copy link
Contributor

@denisristic Please consider covering the updated behavior with integration test.

ADDED test testGetChildrenSroted() to integration testsuite Magento\Catalog\Model\Category
Denis Ristic added 3 commits October 11, 2017 15:50
ADDED $recursive and $isActive, flags to getChildren()
@ishakhsuvarov ishakhsuvarov added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 13, 2017
@okorshenko okorshenko merged commit 79693c8 into magento:2.2-develop Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants