Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Total Amount" cart rule without tax #12396

Closed
Chei20 opened this issue Nov 22, 2017 · 8 comments
Closed

"Total Amount" cart rule without tax #12396

Chei20 opened this issue Nov 22, 2017 · 8 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Chei20
Copy link

Chei20 commented Nov 22, 2017

It seems that if I want to create a cart Price rule that takes account the subtotal of a subselection of products, that subtotal is calculated without taxes, also if in tax configuration everything is configurated as “including tax”.
I want to create a fixed amount discount for whole cart (10€) to all users that have in their cart 60€ of products from one category (123456)

Preconditions

  1. Magento 2

Steps to reproduce

  1. Go to Marketing -> Cart Price Rules

  2. Create a Specific coupon like

  3. (conditions) If “total amount” equals or greater than 59.99 for a subselection of items in cart matching ALL of this conditions
    Category is 123456 (category_id)

  4. (actions) Fixed amount discount for whole cart
    Discount Amount 10

  5. On FrontEnd go to that category 123456, and add products where the subtotal is above 60€ but the subtotal (without tax) is bellow 60€
    Summary
    Subtotal (without tax): €57,55
    Subtotal (with tax): €70,21
    Tax (22%): €12,66
    Total : €70,21

  6. In that case the coupon can not be used because the subtotal (without tax) < €59.99
    My tax configuration is like

image

Expected result

  1. I expected that if products price are configurated with including tax, The Total Amount should be calculated with tax, otherwise is difficult to explain to the customer that the coupon will only be used if the subtotal without tax is more than 60€

Actual result

  1. The coupon will be used only if Subtotal without tax is greater than 60€
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 22, 2017
@magento-engcom-team
Copy link
Contributor

@Chei20, thank you for your report.
We've created internal ticket(s) MAGETWO-84316 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 22, 2017
AleksLi added a commit to AleksLi/msi that referenced this issue Feb 17, 2019
 - Added new condition type to give user opportunity to choose the configuration.
@AleksLi AleksLi self-assigned this Feb 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @AleksLi. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@magento-engcom-team
Copy link
Contributor

Hi @Chei20. Thank you for your report.
The issue has been fixed in #21288 by @AleksLi in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 20, 2019
eduard13 pushed a commit to eduard13/magento2 that referenced this issue Mar 20, 2019
…on type to give user opportunity to choose the configuration.
@magento-engcom-team
Copy link
Contributor

Hi @Chei20. Thank you for your report.
The issue has been fixed in #21845 by @eduard13 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 24, 2019
@praniljoshi13
Copy link

Hey same issue i am getting in magento2.2.6 . how to fix it?

@mihaifaget
Copy link

@magento-engcom-team
This is not fixed. If you read the issue's description:

(conditions) If “total amount” equals or greater than 59.99 for a subselection of items in cart matching ALL of this conditions

That "total amount" is still without tax, this PR adds 'subtotal excl tax' to condition cart attributes, but doesn't fix the issue in this task

@tramov
Copy link

tramov commented Jun 6, 2020

This is still an issue in 2.3.5

My migrated Magento 1 coupon is set for E 70, incl. taxes for free shipping.

However, it does not trigger until the ex. taxes are over E 70.

I can fix partly fix this by specifiying a lower amount. But my customers can mix products with different tax rates. Eg. 9% for food, and 21% for the remainder. I need the free shipping to trigger on the total amount including taxes.

@praniljoshi13
Copy link

praniljoshi13 commented Jun 17, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

7 participants