-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception Error in Catalog Price Rule while Backend language is not English #12399
Comments
@Drakas thank you for your report. |
Same problem with french language here, on Magento 2.2.0 , Php 7, Mysql 5.6 |
Someone had the same problem 1 year ago Apparently it can be because magento need a date filter to convert the localized date to an internal date "dd/MM/y" instead of "M/d/yy" |
I can confirm it is because the date format, I am able to register a new rule in french language if I set it to an MM/DD/YY format (that's why we couldn't do it for black friday @Drakas) |
Same problem in M2.2.2 with italian localization... it's a very annoying issue because we need to launch our website asap and this issue is currently blocking it! |
Same problem here. Magento 2.2.3, Italian localization. Currently working on it. |
seriously, we have some ecommerce to publish and no one has yet made a backport for version 2.2 (besides the fact that nobody knows when the 2.3 will be released) |
I'm resolving with a plugin to reformat dates before they get to the method that throws the exception. Frankly I think this is a poor fix, but gets the job done and that's better than nothing until we get a better one. If I manage to fix this I'll post some code here. |
Comment editedYesterday I published a quick fix in this comment but it wasn't helping much. I think you should try with this: https://github.com/Magonex/module-datetime Other issues that seem to be related can be found here: |
I found a solution, please try to follow this fix: `
` these lines are present in module-sales-rule but not in module-catalog-rule |
Still seeing the issue in 2.2.3 when user is set to British English. |
Based on @Cristiano81 comment i created this patch that you can apply until this is resolved: |
@LucaGallinari 'spatch is working fine, @magento-engcom-team it's possibile to include it in 2.2.7 release? |
Would be fantastic
… Il giorno 21 set 2018, alle ore 11:14, Cristian Sedaboni ***@***.***> ha scritto:
@LucaGallinari 'spatch is working fine, @magento-engcom-team it's possibile to include it in 2.2.7 release?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
#squashtoberfest |
@magento-engcom-team give me 2.3-develop instance |
Hi @larsroettig. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @larsroettig, here is your Magento instance. |
Error can reproduce in 2.3 vanilla Instance is not fixed in 2.3 https://www.youtube.com/watch?v=xBMxMfKHmuc&feature=youtu.be |
Hi @Drakas. Thank you for your report.
The fix will be available with the upcoming 2.3.1 release. |
…ice Rule while Backend language is not English #19074
Preconditions
Steps to reproduce
Expected result
Actual result
Error detailed from exception.log:
main.CRITICAL: DateTime::__construct(): Failed to parse time string (22/11/2017) at position 0 (2): Unexpected character {"exception":"[object] (Exception(code: 0): DateTime::__construct(): Failed to parse time string (22/11/2017) at position 0 (2): Unexpected character at /home/zboutiqf/public_html/nuovo_magento/vendor/magento/module-rule/Model/AbstractModel.php:399)"} []
IMPORTANT:
With Backend language set to English the error does not occur, only with Italian language.
The text was updated successfully, but these errors were encountered: