-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product model in frontend does not contain price including tax #13957
Comments
@tdgroot, thank you for your report. |
Hi @mishanino. Thank you for working on this issue.
|
Hi @vshatylo. Thank you for working on this issue.
|
…uding tax ,display final price using pricing
Look like it has been fixed in: #20011 |
Issue need to be re-confirmed. |
Hi @shikhamis11. Thank you for working on this issue.
|
thanks @swnsma , I will check this |
@magento-engcom-team give me 2.3-develop instance |
Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @shikhamis11, here is your Magento instance. |
It seems this issue is already fixed so closing this one |
Preconditions
Steps to reproduce
5.05
.6.11
)product:price:amount
in head.Expected result
product:price:amount
contains price including tax.Actual result
product:price:amount
contains price excluding tax, as entered in Magento backend.The problem
This issue describes one of many issues, related to the same problem. Here's another example:
When you fetch the final price from the product model, it returns the price as it's entered in the backend. In a lot of code, this behavior is not taken into account. See the template of that generates the output of the
product:price:amount
issue: general.phtml. It just renders the final price of the product.We can also see the rendering of the price being implemented to take prices including tax into account: View.php.
I created the following class to workaround the problem in some scenarios, but I really think this problem should be addressed in Magento core. CatalogProductFinalPrice.php
The text was updated successfully, but these errors were encountered: