Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product model in frontend does not contain price including tax #13957

Closed
tdgroot opened this issue Mar 5, 2018 · 11 comments
Closed

Product model in frontend does not contain price including tax #13957

tdgroot opened this issue Mar 5, 2018 · 11 comments
Assignees
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@tdgroot
Copy link
Member

tdgroot commented Mar 5, 2018

Preconditions

  1. Magento 2.2.3
  2. Configured tax zone and rule so tax is being calculated. (in my case 21% vat for the Netherlands)
  3. Configured tax like the following:
    image

Steps to reproduce

  1. Create a product with the price of 5.05.
  2. Visit the product in frontend
  3. Price is including tax (in my case 6.11)
  4. Open browser inspector
  5. Find meta element product:price:amount in head.
    image

Expected result

  1. Meta element product:price:amount contains price including tax.

Actual result

  1. Meta element product:price:amount contains price excluding tax, as entered in Magento backend.

The problem

This issue describes one of many issues, related to the same problem. Here's another example:
image

When you fetch the final price from the product model, it returns the price as it's entered in the backend. In a lot of code, this behavior is not taken into account. See the template of that generates the output of the product:price:amount issue: general.phtml. It just renders the final price of the product.

We can also see the rendering of the price being implemented to take prices including tax into account: View.php.

I created the following class to workaround the problem in some scenarios, but I really think this problem should be addressed in Magento core. CatalogProductFinalPrice.php

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Mar 5, 2018
@magento-engcom-team
Copy link
Contributor

@tdgroot, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added the Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release label Mar 6, 2018
@mishanino mishanino self-assigned this Nov 2, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 2, 2018

Hi @mishanino. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@mishanino mishanino removed their assignment Nov 2, 2018
@vshatylo vshatylo self-assigned this Jan 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @vshatylo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

vshatylo added a commit to vshatylo/magento2 that referenced this issue Jan 30, 2019
…uding tax ,display final price using pricing
@swnsma
Copy link
Contributor

swnsma commented May 10, 2019

Look like it has been fixed in: #20011

@swnsma
Copy link
Contributor

swnsma commented May 10, 2019

Issue need to be re-confirmed.

@m2-assistant
Copy link

m2-assistant bot commented May 10, 2019

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@swnsma swnsma removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels May 10, 2019
@shikhamis11
Copy link
Member

thanks @swnsma , I will check this

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-13957-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11
Copy link
Member

It seems this issue is already fixed so closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

6 participants