Move validation of Mage_Customer_Model_Address to another class

[stalniy]

There is no ability to change validation rules for Mage_Customer_Model_Address (Mage_Customer_Model_Address_Abstract::validate). For example, I changed "is_required" field for attribute "lastname" to false and when i was trying to place order without lastname field i got an error: Please enter the last name.

I want to customize validate logic and there is only 2 bad ways (rewrite model, place the same file to app/code/local). I think the best solution is validator. Something like this should be (pseudo code):

 class AddressForm {
      public function __construct($model) {
           $this->_configure();
           $this->_fillByModel();
      }

      protected function _configure() {
           $this->addField('firstname')->addValidator(new ValidatorEmpty());
           ....................................(the same for each field that i want to see in form and validate)
      }

      public function isValid() {
           for each validator do {
                $validator->validate();
           }
           return $result;
      }
 }

Usage:
$form = new AddressForm($quote->getBillingAddress());
if ($form->isValid()) {
$quote->getBillingAddress()->save();
}

I think that it's better if validation process is in controller then it will easy to change validation logic. More easy solution for you make checking address attributes for required flag and another rules

[magento-team]

Address validation is implemented in Mage_Customer_Model_Address_Abstract::validate() without the ability to customize validation rules in order to guarantee presence of the required data for any payment method. For instance, last name field cannot be optional because some payment methods require value for it (for example, take a look at "Payer Information Fields" section of the PayPal doc https://cms.paypal.com/us/cgi-bin/?cmd=_render-content&content_ID=developer/e_howto_api_nvp_r_DoDirectPayment).

[stalniy]

What must i do if I dont want to use any online payment method or i want to use payment method that accept only one field - "name"?

[magento-team]

If you don't want to be compatible with online payment methods, as you mentioned previously, class Mage_Customer_Model_Address_Abstract can be rewritten to customize method validate().

[stalniy]

If I want to customize standard checkout then i need to rewrite a lot of code. Because this method "validation" are called everywhere. I need to rewrite quote and quote addresses because class (alias) for quote addresses also hard coded in quote class and maybe some another classes.
Do you think it's ok for getting possibility to change only one method?

[stalniy]

You said that customer class depends from payment methods. Do you think it's ok?

[stalniy]

Ok, the easiest solution:

class Mage_Customer_Model_Address_Abstract  {

          public function validate() {
               return this->getValidator()->validate($this);
          }

          public function setValidator(Mage_Core_Model_Validator_Interface $validator) {
               $this->_validator = $validator;
          }

          public function getValidator() {
               return $this->_validator ? $this->_validator : new Mage_Customer_Model_Address_Validator()
          }
}

And put logic from validate method to Mage_Customer_Model_Address_Validator class into method validate

[LeeSaferite]

I 100% agree with this. Address validation should be a pluggable functionality. You could implement via an interface or an event.

[magento-team]

The feature was approved by the product management and added to the roadmap. However it's not scheduled yet for the execution.
Thank you for the suggestion.