Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations done within a theme that's enabled through a category Design change aren't used #17625

Closed
chefbuitenhuis opened this issue Aug 15, 2018 · 4 comments
Labels
Component: Theme Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@chefbuitenhuis
Copy link

When having an additional theme, which is activated for a certain category, and with certain translations, they are not picked up by Magento. Magento seems to only collect the translation files for the active main theme, which results in the inability to use different translations within the additional theme.

(Jesse Buitenhuis)

Preconditions

  1. Magento 2.2.x
  2. PHP 7.x

Steps to reproduce

  1. Enable Magento_Blank for the website
  2. Create a category and set Magento_Luma as it's theme
  3. Add a translation to the /i18n/ directory of Magento_Luma
  4. Flush caches
  5. The translation is now not applied.

Expected result

  1. The translation within the i18n file has been applied.

Actual result

  1. The translation isn't applied.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chefbuitenhuis. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@chefbuitenhuis do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost self-assigned this Aug 15, 2018
@ghost
Copy link

ghost commented Aug 15, 2018

@chefbuitenhuis, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Theme labels Aug 15, 2018
@ghost ghost removed their assignment Aug 15, 2018
@sidolov
Copy link
Contributor

sidolov commented Nov 8, 2018

Hi @chefbuitenhuis. Thank you for your report.
The issue has been fixed in #18998 by @cezary-zeglen in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 8, 2018
@sidolov sidolov closed this as completed Nov 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chefbuitenhuis. Thank you for your report.
The issue has been fixed in #17854 by @cezary-zeglen in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants