Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations of category design theme not being applied #17794

Closed

Conversation

magently
Copy link

Description

Currently if you enable custom design theme for category the translations of selected theme are not used. This commit fixes the problem.

Fixed Issues (if relevant)

#17625

Manual testing scenarios

(Copied from #17625 )

  1. Enable Magento_Blank for the website
  2. Create a category and set Magento_Luma as it's theme
  3. Add a translation to the /i18n/ directory of Magento_Luma
  4. Flush caches
  5. The translation is now not applied.
    Commit changes point 5. so the translation is being applied

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Cezary Zeglen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team magento-engcom-team added Component: Catalog Component: Framework/Translate USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to translation in Catalog use just Catalog Release Line: 2.2 labels Aug 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magently
Copy link
Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your request. I'm working on Magento instance for you

@magently magently closed this Aug 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @magently, here is your new Magento instance.
Admin access: https://pr-17794.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@magently magently deleted the fix/categorytranslation branch August 9, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Component: Framework/Translate USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to translation in Catalog use just Catalog Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants