Cart Total is NaN in some circumstances

[rauberdaniel]

Preconditions

1. Magento 2.2.5
2. PHP 7.1
3. MySQL 5.6.27

Steps to reproduce

1. Put two items in the cart, in our case this is one product at 59,80€ incl. Tax and one product at 9,49€ incl. Tax, Shipping is free
2. Apply a coupon code (cart price rule) with 100% discount

Or in comment -> #18027 (comment)

Expected result

1. Cart Total should be 0,00 €

Actual result

1. Cart Total is NaN,N €

This issue might be a parsing issue in the frontend or a rounding issue in the backend, as the /rest/default/V1/guests-cart/…/totals-information returns a JSON response including "grand_total":1.4210854715202e-14 (which is basically 0). Either the Frontend has an issue parsing this value or the backend shouldn’t even return a value that hasn’t been rounded. In some cases this value can even be negative and would result in -NaN,N €.

[magento-engcom-team]

Hi @rauberdaniel. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@rauberdaniel do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[rauberdaniel]

@magento-engcom-team give me 2.2.5 instance

[magento-engcom-team]

Hi @rauberdaniel. Thank you for your request. I'm working on Magento 2.2.5 instance for you

[magento-engcom-team]

Hi @rauberdaniel, here is your Magento instance.
Admin access: https://i-18027-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[ghost]

Hi @rauberdaniel I'm not able to reproduce following steps your described.

[rauberdaniel]

This only appears in conditions where floating point calculations are not accurate. I assume it has to do with taxes (7% in my case).

I tried reproducing in the magento instance you offered me, but that instance does not update its index automatically (I assume no cronjob running) and therefore does not allow to create any products (refresh index on save doesn’t seem to work either and manual reindex is only possible using command line).

[ghost]

@rauberdaniel I try several times but same result, tax 7% and do reindex, cron run cache clean, but not have an NaN

[ghost]

@rauberdaniel And rest api result Any update ?

[rauberdaniel]

Guess I need to set up a vanilla Magento 2.2.5 instance to reproduce this, as the one offered above is not working correctly. However, I don’t currently have time for that. Might also have to do something with tax and discount calculation (post or pre tax). Will let you know as soon as I had time for it. Thank you!

[ghost]

@rauberdaniel ok somehow i'm get this result but not in grand total

[ghost]

@rauberdaniel yes finally i'm reproduce this :)

[rauberdaniel]

Great to hear, thank you very much for the help! This is a critical issue for us, as it prevents going past the payment method step in checkout, as no payment methods are available for a NaN price.

[ghost]

@rauberdaniel, thank you for your report.
We've acknowledged the issue and added to our backlog.

[jayankaghosh]

What can I do to reproduce this issue? I have tried as the OP mentioned and got 0.00 as the total

[jayankaghosh]

Ok nevermind. I reproduced it. Seems to be a floating point precision error. We could round the floating point number to 2 digits, since that's the max precision Magento uses to display prices

[jayankaghosh]

I am working on this

[AndyJAllen]

Still experiencing this on 2.3.3; despite the existence of this line in Total.php:
$amount = is_float($amount) ? round($amount, 4) : $amount;

These were the values I was working with:
Subtotal: $26.00
Shipping & Handling: 14.16
Discount: -$40.16 (Used coupon code for 100% discount)
Tax: $0.00

Even though it showed isNaN on the order summary; it still let me check out and create the order.

@shikhamis11
@jayankaghosh

[krzysztofkuzniar]

@AndyJAllen I confirm, in 2.3.3 still display NaN value in that case.

[m2-assistant]

Hi @jayankaghosh. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

HI @krzysztofkuzniar . I am not able to reproduce issue by steps from comment on 2.4-develop.

Are you facing with this issue on branch 2.4-develop?

[engcom-Delta]

@krzysztofkuzniar, we are closing this issue due to inactivity. If you'd like to update it, please reopen the issue.