Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element 'css', attribute 'as': The attribute 'as' is not allowed. (CSS preloading) #18347

Closed
benoitrenaud opened this issue Oct 2, 2018 · 7 comments
Closed

Element 'css', attribute 'as': The attribute 'as' is not allowed. (CSS preloading) #18347

benoitrenaud opened this issue Oct 2, 2018 · 7 comments
Labels
Component: Framework/View Component: Theme Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@benoitrenaud
Copy link

Hi,
We want to use a technique for loading asynchronous stylesheets.
Ex. https://brianflove.com/2016/07/21/preloading-with-critical-path-css/

The issue is that link attribute "as" isn't valid according to vendor/magento/framework/View/Layout/etc/head.xsd validation file but is a officially supported HTML link attribute as described here:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#Attributes

Preconditions

  1. Magento 2.2.6
  2. PHP 7.1

Steps to reproduce

  1. I add the attribute AS on my css inclusion:
<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <head> 
        <css src="/style.css" src_type="url" rel="preload" as="style" /> 
    </head>
</page>
  1. Clear cache
  2. Reload the front

Expected result

  1. Permit the AS attribute (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#Attributes) in this file vendor/magento/framework/View/Layout/etc/head.xsd
  2. Add this <xs:attribute name="as" type="xs:string"/> under <xs:complexType name="linkType">

Actual result

An exception is thrown by Magento Framework 1 exception(s): Exception #0 (Magento\Framework\Config\Dom\ValidationException): Element 'css', attribute 'as': The attribute 'as' is not allowed.
@magento-engcom-team
Copy link
Contributor

Hi @benoitrenaud. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@benoitrenaud do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 2, 2018
@benoitrenaud benoitrenaud changed the title Element 'css', attribute 'order': The attribute 'as' is not allowed. (CSS preloading) Element 'css', attribute 'as': The attribute 'as' is not allowed. (CSS preloading) Oct 3, 2018
@ghost ghost self-assigned this Nov 9, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 9, 2018 •
edited by ghost
Loading

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Theme Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Nov 9, 2018
@ghost
Copy link

ghost commented Nov 9, 2018

Hi @benoitrenaud thank you for you report, as devdocs says https://devdocs.magento.com/guides/v2.0/frontend-dev-guide/layouts/xml-instructions.html attribute AS may be supported.

@ghost ghost added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 9, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96253, MAGETWO-96254 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 9, 2018
@ghost ghost removed their assignment Nov 9, 2018
@vasilii-b vasilii-b self-assigned this Jan 23, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 23, 2019 •
edited by vasilii-b
Loading

Hi @vasilii-b. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Jan 23, 2019
magento#18347 - Element 'css', attribute 'as': The attribute 'as' is …
57f6957 
…not allowed. (CSS preloading)

- Added as attribute to linkType with 3 possible options: style, script and font
@vasilii-b vasilii-b mentioned this issue Jan 23, 2019
Merged
4 tasks
@vasilii-b vasilii-b added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Jan 23, 2019
@vasilii-b vasilii-b removed their assignment Jan 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @benoitrenaud. Thank you for your report.
The issue has been fixed in #20495 by @vasilii-b in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 15, 2019
magento-engcom-team added a commit that referenced this issue Feb 15, 2019
@magento-engcom-team
ENGCOM-3932: #18347 - Element 'css', attribute 'as': The attribute 'a…
fc3f90b 
…s' is not allowed. (CSS preloading) #20495

 - Merge Pull Request #20495 from vasilii-b/magento2:2.3-framework-view-element-css-attribute-as
 - Merged commits:
   1. 57f6957
magento-engcom-team pushed a commit that referenced this issue Feb 15, 2019
@sidolov
ENGCOM-3932: #18347 - Element 'css', attribute 'as': The attribute 'a…
8523755 
…s' is not allowed. (CSS preloading) #20495
@amol2jcommerce amol2jcommerce mentioned this issue Feb 15, 2019
Merged
4 tasks
amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this issue Feb 15, 2019
magento#18347 - Element 'css', attribute 'as': The attribute 'as' is …
46572af 
…not allowed. (CSS preloading)

- Added as attribute to linkType with 3 possible options: style, script and font
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @benoitrenaud. Thank you for your report.
The issue has been fixed in #21261 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

magento-engcom-team added a commit that referenced this issue Feb 18, 2019
@magento-engcom-team
ENGCOM-4286: [Backport] #18347 - Element 'css', attribute 'as': The a…
df0b981 
…ttribute 'as' is not allowed. (CSS preloading) #21261

 - Merge Pull Request #21261 from amol2jcommerce/magento2:2.2-develop-PR-port-20495
 - Merged commits:
   1. 46572af
magento-engcom-team pushed a commit that referenced this issue Feb 18, 2019
@sivaschenko
ENGCOM-4286: [Backport] #18347 - Element 'css', attribute 'as': The a…
2d15143 
…ttribute 'as' is not allowed. (CSS preloading) #21261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Framework/View Component: Theme Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sdzhepa @benoitrenaud @vasilii-b @magento-engcom-team