Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant delete the sample link #18847

Closed
Mor10Mort opened this issue Oct 26, 2018 · 9 comments
Closed

Cant delete the sample link #18847

Mor10Mort opened this issue Oct 26, 2018 · 9 comments
Labels
Component: Downloadable Event: squashtoberfest Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Mor10Mort
Copy link

Mor10Mort commented Oct 26, 2018

Preconditions (*)

  1. Magento ver. 2.2.6

Steps to reproduce (*)

  1. Created a "sample link" for a "Downloadable product"
  2. I try to delete the "sample link", but upon saving, the link keeps reappearing (both in front and backend (of the product)

Expected result (*)

  1. I expected that the sample link would be deleted from backend and on product page.

Actual result (*)

  1. The sample link is still there after trying to delete it.
    linkdoesntremovefrontendeither

samplelinkcantbedeleted

Additional information

  1. Additional clarification for steps to reproduce from comment Cant delete the sample link #18847 (comment)

Presently, I am able to reproduce this issue on magento instance and my local system as well. To reproduce this issue one more step is required which is missing in issue description.
Here, If we directly create sample link and save than it work as expected. If we delete that sample link than it will be delete too.
But, If we set Link and Sample and press save than it work as expected. If we delete that sample link than issue is arised.
Third case, If we delete both the link than both get deleted. No issue arise.
So, we have to fix for second case only.

@magento-engcom-team
Copy link
Contributor

Hi @Mor10Mort. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@Mor10Mort do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 26, 2018
@Shubham0492
Copy link

#SQUASHTOBERFEST

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@hiren0241
Copy link
Contributor

@magento-engcom-team give me 2.2.6 instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento 2.2.6 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18847-2-2-6//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@hiren0241
Copy link
Contributor

hiren0241 commented Oct 27, 2018

@magento-engcom-team Presently, I am able to reproduce this issue on magento instance and my local system as well. To reproduce this issue one more step is required which is missing in issue description.

Here, If we directly create sample link and save than it work as expected. If we delete that sample link than it will be delete too.

But, If we set Link and Sample and press save than it work as expected. If we delete that sample link than issue is arised.

Third case, If we delete both the link than both get deleted. No issue arise.

So, we have to fix for second case only.

@hiren0241 hiren0241 added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Nov 3, 2018
@swnsma swnsma self-assigned this Nov 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@swnsma swnsma added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Component: Downloadable Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 10, 2018
@magento-engcom-team
Copy link
Contributor

@swnsma Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96269, MAGETWO-96270 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 10, 2018
swnsma pushed a commit to swnsma/magento2-1 that referenced this issue Nov 10, 2018
- remove downloadable product links and samples if it were not provided in request.
@swnsma swnsma removed their assignment May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Downloadable Event: squashtoberfest Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants