Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong price amount in opengraph #20010

Closed
jcourtei opened this issue Dec 28, 2018 · 16 comments · Fixed by #20011
Closed

Wrong price amount in opengraph #20010

jcourtei opened this issue Dec 28, 2018 · 16 comments · Fixed by #20011
Labels
Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@jcourtei
Copy link

Preconditions (*)

Version 2.2.6 (Community Edition).

Steps to reproduce (*)

  1. Several store views with several currency rates.
  2. View source code of a simple product in a store view with a currency (USD) different from the base currency (EUR).

Expected result (*)

Meta tag "product:price:amount" should contain the price converted in USD.

Actual result (*)

Meta tag "product:price:amount" contains the price in EUR.
Meta tag "product:price:currency" on the other hand is correct (USD).

In module-catalog/view/frontend/templates/product/view/opengraph/general.phtml the following line is wrong :
<?php if ($priceAmount = $block->getProduct()->getFinalPrice()):?>
It should be :
<?php if ($priceAmount = $block->getProduct()->getPriceInfo()->getPrice('final_price')->getValue()):?>

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @jcourtei. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@jcourtei do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@milindsingh milindsingh self-assigned this Dec 28, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 28, 2018

Hi @milindsingh. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@milindsingh milindsingh added Component: Catalog Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Dec 28, 2018
@milindsingh
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh, here is your Magento instance.
Admin access: https://i-20010-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@milindsingh milindsingh added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Dec 28, 2018
@milindsingh
Copy link
Member

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh, here is your Magento instance.
Admin access: https://i-20010-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@milindsingh milindsingh added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 28, 2018
@magento-engcom-team
Copy link
Contributor

@milindsingh Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97381, MAGETWO-97382 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 28, 2018
@milindsingh milindsingh removed their assignment Dec 28, 2018
@milindsingh milindsingh added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Dec 28, 2018
milindsingh added a commit to opencommerce/magento2 that referenced this issue Dec 28, 2018
Issue fix magento#20010 Wrong price amount in opengraph
@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 8, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-20010-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @jcourtei. Thank you for your report.
The issue has been fixed in #20011 by @milindsingh in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming release.

magento-engcom-team added a commit that referenced this issue Feb 13, 2019
 - Merge Pull Request #20011 from opencommerce/magento2:2.3-issue-20010
 - Merged commits:
   1. 5ee1d42
mage2pratik pushed a commit to mage2pratik/magento2 that referenced this issue Feb 13, 2019
Issue fix magento#20010 Wrong price amount in opengraph
@magento-engcom-team
Copy link
Contributor

Hi @jcourtei. Thank you for your report.
The issue has been fixed in #21202 by @mage2pratik in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 23, 2019
magento-engcom-team added a commit that referenced this issue Feb 23, 2019
…aph #21202

 - Merge Pull Request #21202 from mage2pratik/magento2:2.2-develop-PR-port-20011
 - Merged commits:
   1. 85cdc9d
@wssweb
Copy link

wssweb commented Jul 12, 2019

The open graph price tag is still incorrect in 2.3.2 when Minimum Advertised Price is enabled. The price used will be Price, and not Manufacturer's Suggested Retail Price. Search engines like Google will use the open graph tag to override the price displayed on the page in their search results, which will cause you to violate any normal IMAP agreement.

@tprocter1984
Copy link

tprocter1984 commented Aug 4, 2022

This is still an issue with grouped products on version 2.4.0, I'll update to 2.4.4 but I don't see any fixes that will help.

My store is setup in British Pounds with 20% tax

The "Set of Sprite Yoga Straps" returns:
<meta property="product:price:amount" content="14"/>

This should be:
<meta property="product:price:amount" content="16.80"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants