Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gift option message overlap edit and remove button #20604

Closed
ajay2jcommerce opened this issue Jan 25, 2019 · 13 comments
Closed

Gift option message overlap edit and remove button #20604

ajay2jcommerce opened this issue Jan 25, 2019 · 13 comments
Assignees
Labels
Area: Frontend Component: GiftMessage Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ajay2jcommerce
Copy link

Preconditions (*)

  1. 2.3.0

Steps to reproduce (*)

  1. Login Admin
  2. Go to Store >> Configuration >> sales >> sales >>gift option>> enable both settings
  3. add product to cart.
  4. add gift option massage.

Expected result (*)

expectedt

Actual result (*)

actual

@magento-engcom-team
Copy link
Contributor

Hi @ajay2jcommerce. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@ajay2jcommerce do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 25, 2019
@nainesh2jcommerce nainesh2jcommerce self-assigned this Jan 25, 2019
@nainesh2jcommerce nainesh2jcommerce added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Jan 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@nainesh2jcommerce
Copy link
Contributor

@magento-engcom-team give me 2.3.0 instance

@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for your request. I'm working on Magento 2.3.0 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce, here is your Magento instance.
Admin access: https://i-20604-2-3-0.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@nainesh2jcommerce nainesh2jcommerce added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 25, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 25, 2019
@magento-engcom-team
Copy link
Contributor

@nainesh2jcommerce Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97922 were created

@irajneeshgupta
Copy link
Member

irajneeshgupta commented Jan 25, 2019

@nainesh2jcommerce @engcom-backlog-nazar
you are wasting the instance per issue, if you do not need it... don't ask engcom team bot for new instances.I checked that you have not tested anything in this instance.

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Jan 25, 2019

Hi @irajneeshgupta,

Instance which I requested to engcom team in that I am able to re-produce the issue and I have created test product in that to verify issue. How you mentioned that I haven't checked anything in that instance.

Also for your confirmation please check attachment in which I have created product along with case on shopping cart.
image

Please check properly from you end after that raise issue in ticket also PR already generated for this ticket.

@ghost ghost self-assigned this Jan 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@irajneeshgupta
Copy link
Member

@nainesh2jcommerce
previously you tested in another instance and when i reported , you edited/deleted your messages.
not expected these things , play with your instances good luck.
download

@ghost ghost added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 25, 2019
@ghost
Copy link

ghost commented Jan 25, 2019

Hi @irajneeshgupta can confirm this iss
selection_289
ue exist on 2.3-develop

@ghost ghost removed their assignment Jan 25, 2019
@ajay2jcommerce ajay2jcommerce changed the title Gift option massage overlap edit and remove button Gift option message overlap edit and remove button Jan 25, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ajay2jcommerce. Thank you for your report.
The issue has been fixed in #20605 by @ajay2jcommerce in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@magento-engcom-team
Copy link
Contributor

Hi @ajay2jcommerce. Thank you for your report.
The issue has been fixed in #20784 by @ajay2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: GiftMessage Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants