Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gift-option-message-overlap-edit-and-remove-button ::Gift option mess… #20605

Conversation

ajay2jcommerce
Copy link

…age overlap edit and remove button.

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2 Gift option message overlap edit and remove button #20604: Gift option massage overlap edit and remove button

Manual testing scenarios (*)

  1. Login Admin
  2. Go to Store >> Configuration >> sales >> sales >>gift option>> enable both settings
  3. add product to cart.
  4. add gift option massage.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ajay2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ajay2jcommerce ajay2jcommerce changed the title Gift-option-massage-overlap-edit-and-remove-button ::Gift option mass… Gift-option-message-overlap-edit-and-remove-button ::Gift option mess… Jan 25, 2019
@sdzhepa sdzhepa self-assigned this Jan 28, 2019
@sdzhepa sdzhepa self-requested a review January 28, 2019 14:14
@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 28, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20605.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 28, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-20605-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, thank you for the review.
ENGCOM-3985 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 31, 2019

Hi @ajay2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 93b34b0 into magento:2.3-develop Jan 31, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants