Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magento/ImportExport/Model/Import has _coreConfig declared dynamically #21998

Closed
kisroman opened this issue Mar 28, 2019 · 3 comments
Closed

Magento/ImportExport/Model/Import has _coreConfig declared dynamically #21998

kisroman opened this issue Mar 28, 2019 · 3 comments
Assignees
@kisroman
Labels
Component: ImportExport Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@kisroman
Copy link
Contributor

Preconditions (*)

Steps to reproduce (*)

  1. See Magento/ImportExport/Model/Import class.
  2. Find _coreConfig in construct.

Expected result (*)

  1. Field should no be declared dynamically

Actual result (*)

  1. Field is declared dynamically
@kisroman kisroman self-assigned this Mar 28, 2019
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 28, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 28, 2019 •
edited by kisroman
Loading

Hi @kisroman. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@kisroman do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

kisroman added a commit to kisroman/magento2 that referenced this issue Mar 28, 2019
@kisroman
magento#21998 Magento/ImportExport/Model/Import has _coreConfig decla…
1fe977a 
…red dynamically
@kisroman kisroman mentioned this issue Mar 28, 2019
Merged
4 tasks
@Nazar65 Nazar65 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: ImportExport Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Mar 28, 2019
@shikhamis11 shikhamis11 added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Mar 29, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 29, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98979 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @kisroman. Thank you for your report.
The issue has been fixed in #21999 by @kisroman in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 9, 2019
magento-engcom-team added a commit that referenced this issue Apr 9, 2019
@magento-engcom-team
ENGCOM-4600: #21998 Magento/ImportExport/Model/Import has _coreConfig…
c3b2e09 
… declared dyn… #21999

 - Merge Pull Request #21999 from kisroman/magento2:21998
 - Merged commits:
   1. 1fe977a
magento-engcom-team pushed a commit that referenced this issue Apr 9, 2019
@sivaschenko
ENGCOM-4600: #21998 Magento/ImportExport/Model/Import has _coreConfig…
87d0c7d 
… declared dyn… #21999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kisroman kisroman

Labels
Component: ImportExport Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Nazar65 @shikhamis11 @magento-engcom-team @kisroman