Programatically created invoices miss items when both simple products and bundled products are mixed in an order

[ryanpalmerweb]

Preconditions (*)

1. Magento 2.3.1

Steps to reproduce (*)

1. Create an order containing both a bundled product and a simple product
2. Check out with a payment method which does not automatically create an invoice
3. Programatically get an instance of the order, and then run the following code

$invoice = $order->prepareInvoice();
$invoice->getOrder()->setIsInProcess(true);
$invoice->register()->pay();
$invoice->save();

Expected result (*)

1. All of the items in the invoice should be ordered

Actual result (*)

1. Only the bundled product will be invoiced, the simple product will be ignored, causing a partial invoice to be created

Explanation

1. Payment modules commonly call $order->prepareInvoice()
2. This calls Magento\Sales\Model\Service\InvoiceService->prepareInvoice()
3. New logic introduced by 2fb6b3b populates the quantity for the bundled products but not the simple products.
4. $qtys is no longer empty causing the following code to fail on the simple products

foreach ($order->getAllItems() as $orderItem) {
...
if (empty($qtys)) {
      $qty = $orderItem->getQtyToInvoice();
}

5. $this->setInvoiceItemQuantity($item, $qty); now sets a zero quantity, meaning that $invoiceItem->getQty() returns 0 instead of $orderItem->getQtyToInvoice();
6. Instead of registering simple items for the invoice, the following code now acts as if the simple items have been deleted,

foreach ($this->getAllItems() as $item) {
    if ($item->getQty() > 0) {
        $item->register();
    } else {
        $item->isDeleted(true);
    }
}

[m2-assistant]

Hi @ryanpalmerweb. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ryanpalmerweb do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[ryanpalmerweb]

Here's an example showing the order overview when it happens - the top product is a bundle and the bottom is a simple

[m2-assistant]

Hi @maheshWebkul721. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.
  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

[magento-engcom-team]

Hi @ryanpalmerweb. Thank you for your report.
The issue has been fixed in #22263 by @ryanpalmerweb in 2.3-develop branch
Related commit(s):

• ec2c6ca7df68de9aaccecfb899b102a2a3eaa631

The fix will be available with the upcoming 2.3.2 release.

[dphilipps]

Thank you - we were experiencing this bug on 2.3.1, I have applied patch and now working again. Cheers.

[simiMart26]

This is issue is still happening on magento 2.3.2