Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert variable in existing Email Template #22502

Closed
stoutik opened this issue Apr 26, 2019 · 3 comments
Closed

Insert variable in existing Email Template #22502

stoutik opened this issue Apr 26, 2019 · 3 comments
Assignees
Labels
duplicate Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@stoutik
Copy link

stoutik commented Apr 26, 2019

Preconditions (*)

  1. Magento CE 2.3.1

Steps to reproduce (*)

  1. Navigate to Admin
  2. Go to : Marketing > Communication > Email Templates >
  3. Click to edit an existing template
  4. Click button "Insert Variable..."
  5. Show browser console

Expected result (*)

  1. Modal with listing variables

Actual result (*)

  1. Nothing
    image

Proposed solution

  • In /vendor/magento/module-email/Block/Adminhtml/Template/Edit/Form.php (Line 114).
    $this->serializer->serialize($this->getVariables()) this line return an object.
  • In /vendor/magento/module-email/view/adminhtml/web/js/variables.js (Line 53)
    variables.each(function (variableGroup) {..., each function not working with Object, use for or other looping method.
@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @stoutik. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@stoutik do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 26, 2019
@krishprakash krishprakash self-assigned this Apr 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

Hi @stoutik. Thank you for your report.
Issue is duplicate to #20111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

3 participants