Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS scripts to the end of body tag #329

Closed
sverdier opened this issue Aug 2, 2013 · 3 comments
Closed

JS scripts to the end of body tag #329

sverdier opened this issue Aug 2, 2013 · 3 comments
Assignees

Comments

@sverdier
Copy link

sverdier commented Aug 2, 2013

Hi,

Can you place inline JS scripts to the end of body tag like http://html5boilerplate.com/
We can use ZF function in template view for that $this->inlineScript()->appendScript('alert('my js code')');

And can you move all JS scripts to the end of body tag?
We can use ZF function $this->headScript()->prependScript('...');

Thanks

@verklov
Copy link
Contributor

verklov commented Apr 21, 2014

@sverdier, thank you for the suggested improvement! I have forwarded this suggestion to the PM responsible for JS improvements. We will get back to you once we have made the decision.

@tkacheva
Copy link

tkacheva commented Jun 2, 2014

@sverdier, we are adopting RequireJS to Magento. Will it solve your issue?

@maksek maksek added the CS label Nov 12, 2014
@mcspronko
Copy link
Contributor

@sverdier, you may want to check RequireJS library usage in Magento 2. Should you have questions, please let us know.

@maksek maksek closed this as completed Nov 12, 2014
magento-team pushed a commit that referenced this issue May 29, 2015
[Folks] Define Public API & Bugfix
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Fixed issue:
 - MAGETWO-57894: [Backport] Compiler Performance Optimisation 2.0
magento-engcom-team added a commit that referenced this issue Feb 1, 2019
 - Merge Pull Request magento/graphql-ce#329 from dominicfernando/graphql-ce:add-missing-php-doc-function-comment
 - Merged commits:
   1. 040e5b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants