-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not possible to order top menu items #3446
Comments
This issue may be resolved by fixing #2354 |
Thank you for your submission. We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues. Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here). We are closing this GitHub ticket and have moved your request to the new forum. |
[pangolin] MFTF 2.3.11 update for CE 2.2-develop
When I observe
page_block_html_topmenu_gethtml_before
event, just likeMagento\Catalog\ObserverAddCatalogToTopmenuItemsObserver
does, and add some items to thetop.menu
, I can't order the items I add (whether it should be displayed before or after category listing, for example).I think it should be possible, since the "top menu" must be one of the first and most modified element on any website.
Maybe by adding a special
\Magento\Framework\DataObject
attribute "order" which will be used inside or beforeMagento\Theme\Block\Html
's_getHtml
method, in a way to reorder the\Magento\Framework\Data\Tree\Node
before rendering it ?Or even clearer : adding a
$_position
property to theNode
class, and a non-mandatory variable to theNode
class constructor, which could be used in a similar way I expressed before ?Simple, non-breaking, no performance issue, really useful. Right ?
I can try to make a pull request if you accept this issue.
The text was updated successfully, but these errors were encountered: