Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print pdf don't delete file in var folder #3535

Closed
quienti opened this issue Feb 24, 2016 · 7 comments
Closed

Print pdf don't delete file in var folder #3535

quienti opened this issue Feb 24, 2016 · 7 comments
Labels
bug report Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted

Comments

@quienti
Copy link
Contributor

quienti commented Feb 24, 2016

Magento 2.0.2

If we print a pdf in Shipment :
sans titre 1

We generate the file in folder var :
sans titre 2

But, this file is never delete !

If we look in this file :
https://github.com/magento/magento2/blob/2.0/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php#L99-L101

This code doesn't work for pdf files, but this code work fine for csv files like export customer

@quienti quienti changed the title Print pdf not delete file in var folder Print pdf don't delete file in var folder Feb 24, 2016
@NadiyaS NadiyaS added PS Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed CS labels Jun 8, 2016
@NadiyaS NadiyaS assigned joanhe and unassigned NadiyaS Jun 8, 2016
@NadiyaS
Copy link
Contributor

NadiyaS commented Jun 8, 2016

Hi @quienti ,
thank you for reporting this issue. Internal ticket MAGETWO-54083 was created.

@vkorotun vkorotun removed the PS label Aug 4, 2016
@joanhe joanhe removed their assignment Aug 17, 2016
@AntonEvers
Copy link
Contributor

Isn't it strange that the PDF's are dropped in the var root? I'd rather see them end up in a semantically named subdir or in the var/tmp dir.

@southerncomputer
Copy link
Contributor

southerncomputer commented Apr 14, 2017

Just going to put this here for search engine semantics. If you ever try to print pdf's from the frontend and get no such template {} error. It is because magento forgot to place two files in the frontend for the methods to access their templates..

copy the files from adminhtml/templates/info/pdf* to frontend/templates/info/pdf/*

mkdir vendor/magento/module-payment/view/frontend/templates/info/pdf
mkdir vendor/magento/module-offline-payments/view/frontend/templates/info/pdf

cp vendor/magento/module-payment/view/adminhtml/templates/info/pdf/* vendor/magento/module-payment/view/frontend/templates/info/pdf/
cp vendor/magento/module-offline-payments/view/adminhtml/templates/info/pdf vendor/magento/module-offline-payments/view/frontend/templates/info/pdf/

Hope this saves you hours of frustration from seemingly useless error message when trying to print pdf's from the frontend (or email their attachments!)

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Component: Sales labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 17, 2017
@magento-engcom-team
Copy link
Contributor

@quienti, thank you for your report.
We've created internal ticket(s) MAGETWO-82033 to track progress on the issue.

@magento-engcom-team
Copy link
Contributor

@quienti, thank you for your report.

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

You may learn more about this initiative following this link.

Please feel free to comment or reopen the ticket if you think it should be reviewed once more. Thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

Hi @quienti. Thank you for your report.
The issue has been fixed in #16401 by @rogyar in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 29, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Aug 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @quienti. Thank you for your report.
The issue has been fixed in #17280 by @tiagosampaio in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team pushed a commit that referenced this issue Jan 11, 2019
…ner-inline-focus

[Owls] MC-3812: Text/Banner - Stage Inline Editor becomes focused and editable after clicking Save button on Edit Form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted
Projects
None yet
Development

No branches or pull requests

9 participants