Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletter Subscriber create-date not set, and change_status_at broken #4004

Closed
fvschie opened this issue Apr 5, 2016 · 12 comments
Closed

Newsletter Subscriber create-date not set, and change_status_at broken #4004

fvschie opened this issue Apr 5, 2016 · 12 comments
Assignees
@nemesis-back
Labels
bug report Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@fvschie
Copy link

fvschie commented Apr 5, 2016

Steps to reproduce

  1. Register a newsletter subscriber via the front-end, with no confirmation of email address needed.
  2. Check database.
  3. Unsubscribe user via admin interface.
  4. Resubscribe user via admin interfa... oh wait, this option is missing. If you make a mistake (no confirmation dialog) you can't correct it without going into the DB.

Expected result

  1. After creation set change_status_at to creation date (confirmation of email if enabled, or just registration time if no confirmation email is sent).
  2. change_status_at is set to when user is subscribed.
  3. Expect change_status_at to contain the date of the status change.

Actual result

  1. I want to sync new newsletter subscribers, so I expect a datetime to filter on, to get new newsletter subscribers. This is not set.
  2. change_status_at is null. It would be nice if this were initialized to the registration date.
  3. User is unsubscribed, status 3, but change_status_at remains null. Integration can't detect user is unsubscribed now.
@fvschie
Copy link
Author

fvschie commented Apr 18, 2016

Any update?

@piotrekkaminski
Copy link
Contributor

Internal issue MAGETWO-54128

@vkorotun vkorotun removed the MX label Aug 4, 2016
@fvschie
Copy link
Author

fvschie commented Aug 4, 2016

Hi, what's the status on this story?

@vkorotun vkorotun added linked Component: Customer Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@fvschie
Copy link
Author

fvschie commented Oct 27, 2016

And now? :-)

@fvschie
Copy link
Author

fvschie commented Mar 1, 2017

How's about now?

@schizek
Copy link

schizek commented Jun 15, 2017

What's the status on this?

@PaulBoss
Copy link

So, again, is there an update?

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Customer Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@fvschie, thank you for your report.
We've created internal ticket(s) MAGETWO-54128 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 18, 2017
@nemesis-back
Copy link

I will work on it #SQUASHTOBERFEST 2017

@nemesis-back nemesis-back mentioned this issue Oct 30, 2017
Merged
4 tasks
nemesis-back added a commit to nemesis-back/magento2 that referenced this issue Oct 31, 2017
@nemesis-back
magento#4004: Newsletter Subscriber change_status_at broken
3afed3d
okorshenko pushed a commit that referenced this issue Nov 7, 2017
MAGETWO-83257: #4004: Newsletter Subscriber create-date not set, and …
8fcee2c 
…change_status_at broken #11879

 - Merge Pull Request #11879 from nemesis-back/magento2:bugfix/4004-newsletter-subscriber-change-status
 - Merged commits:
   1. 3afed3d
okorshenko pushed a commit that referenced this issue Nov 7, 2017
MAGETWO-83257: #4004: Newsletter Subscriber create-date not set, and …
60a698d 
…change_status_at broken #11879

 - fixed backward compatibility issue
okorshenko pushed a commit that referenced this issue Nov 7, 2017
MAGETWO-83257: #4004: Newsletter Subscriber create-date not set, and …
a12e731 
…change_status_at broken #11879
@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch. Will be available with 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 7, 2017
@magento-team
Copy link
Contributor

Hi @fvschie. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 26, 2018
magento-team pushed a commit that referenced this issue Jan 26, 2018
#11879: #4004: Newsletter Subscriber create-date not set, and change_…
0fffced 
…status_at broken

 - fixed backward compatibility
@fvschie
Copy link
Author

fvschie commented Mar 16, 2018 •
edited
Loading

Awesome, I am glad to hear it! Thanks a lot. (Any chance of a backport to 2.1.x?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nemesis-back nemesis-back

Labels
bug report Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@magento-team @piotrekkaminski @fvschie @schizek @PaulBoss @okorshenko @vkorotun @MomotenkoNatalia @magento-engcom-team @nemesis-back