Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget condition with unexpected character not preventing from saving #4136

Closed
devhn opened this issue Apr 13, 2016 · 5 comments
Closed

Widget condition with unexpected character not preventing from saving #4136

devhn opened this issue Apr 13, 2016 · 5 comments
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@devhn
Copy link

devhn commented Apr 13, 2016 •
edited by magento-engcom-team
Loading

Preconditions

  1. Magento 2.1

Steps to reproduce

  1. Install Magento from community branch.
  2. Create a new widget via admin (Content -->Widgets)
  3. Widget type: Catalog Products List
  4. Layout update: Specific category
  5. Widget options (conditions): Set product as new from date. Entered value: {TODAY}

Expected result

  1. It should display an error about unexpected character and not allow to save the widget

Actual result

  1. Upon saving the widget it display and error on frontend (attached)
  2. When trying to edit the widget it displays an error on backend (attached)

This happens when using {TODAY} as a time value and not actual formatted date.
Is the {TODAY} parameter obsolete? And will there be an option to delete the widget from the administration in the future as currently there is no selection options with actions within the Widgets section?

errors.zip
@piotrekkaminski
Copy link
Contributor

internal issue MAGETWO-53440

@vkorotun vkorotun removed the MX label Aug 4, 2016
@elenleonova elenleonova removed their assignment Sep 20, 2016
@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 26, 2016
@magento-engcom-team magento-engcom-team added bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Oct 1, 2017
@magento-engcom-team
Copy link
Contributor

@devhn, thank you for your report.
We've created internal ticket(s) MAGETWO-53440 to track progress on the issue.

@vasilii-b
Copy link

vasilii-b commented Jan 23, 2018 •
edited
Loading

I'm gonna have a look on this.

@vasilii-b vasilii-b self-assigned this Jan 23, 2018
@vasilii-b vasilii-b mentioned this issue Mar 24, 2018
Closed
4 tasks
@vasilii-b vasilii-b mentioned this issue Apr 1, 2018
Merged
4 tasks
vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Nov 8, 2018
magento/magento2:magento#4136 - Widget condition with unexpected char…
6c87bb3 
…acter not preventing from saving

- Restricted user to change date input value
- Open datepicker popup once user click on the date to be changed
vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Nov 13, 2018
magento/magento2:magento#4136 - Widget condition with unexpected char…
1d1d061 
…acter not preventing from saving

- Added autocomplete option for calendar.js
@vasilii-b vasilii-b removed their assignment Nov 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @devhn. Thank you for your report.
The issue has been fixed in #14485 by @vasilii-b in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 24, 2018
magento-engcom-team added a commit that referenced this issue Nov 24, 2018
@magento-engcom-team
ENGCOM-3357: Fix for Issue #4136, MAGETWO-53440 #14485
d0c8cfc 
 - Merge Pull Request #14485 from vasilii-b/magento2:issue-4136-2.2-develop
 - Merged commits:
   1. cc1e013
   2. ff4b005
   3. 6c87bb3
   4. 1d1d061
magento-engcom-team pushed a commit that referenced this issue Nov 24, 2018
@VladimirZaets
ENGCOM-3357: Fix for Issue #4136, MAGETWO-53440 #14485
01a7917
@vasilii-b vasilii-b mentioned this issue Nov 24, 2018
Merged
4 tasks
vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Nov 24, 2018
magento/magento2:magento#4136 - Widget condition with unexpected char…
e6323fb 
…acter not preventing from saving

- Restricted user to change date input value
- Open datepicker popup once user click on the date to be changed
vasilii-b pushed a commit to vasilii-b/magento2 that referenced this issue Nov 24, 2018
magento/magento2:magento#4136 - Widget condition with unexpected char…
80fed1b 
…acter not preventing from saving

- Added autocomplete option for calendar.js
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @devhn. Thank you for your report.
The issue has been fixed in #19390 by @vasilii-b in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

magento-engcom-team added a commit that referenced this issue Jan 16, 2019
@magento-engcom-team
ENGCOM-3558: [Forwardport] Fix for Issue #4136, MAGETWO-53440 #19390
7447d5c 
 - Merge Pull Request #19390 from vasilii-b/magento2:2.3-develop-PR-port-14485
 - Merged commits:
   1. 00f4f7d
   2. 4008630
   3. e6323fb
   4. 80fed1b
   5. 747f33d
   6. 740fbd0
magento-engcom-team pushed a commit that referenced this issue Jan 16, 2019
@sivaschenko
ENGCOM-3558: [Forwardport] Fix for Issue #4136, MAGETWO-53440 #19390
f7b8337
magento-engcom-team pushed a commit that referenced this issue Apr 30, 2019
@naydav
Merge pull request #4136 from magento-engcom/graphql-develop-prs
93a8162 
[EngCom] Public Pull Requests - GraphQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@piotrekkaminski @elenleonova @veloraven @okorshenko @vkorotun @MomotenkoNatalia @vasilii-b @devhn @magento-engcom-team