Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some translation keys are not correct. #419

Closed
guoguolong opened this issue Nov 25, 2013 · 2 comments
Closed

Some translation keys are not correct. #419

guoguolong opened this issue Nov 25, 2013 · 2 comments

Comments

@guoguolong
Copy link

I found some keys for translation look not correct as below.

  • Reference in Core module.
    "Add Products to Option ""%s""","Add Products to Option ""%s"""
    "Maximum length of this field must be equal or less than %s symbols.","Maximum length of this field must be equal or less than %s symbols."
    "Please enter a valid day (1-%d).","Please enter a valid day (1-%d)."
    "Please enter a valid year (1900-%d).","Please enter a valid year (1900-%d)."

Shouldn't %d, %s replaced with %1?

  • Reference in Customer module.
    "If you believe this is an error, please contact us at %s","If you believe this is an error, please contact us at %s"

Shouldn't %d, %s replaced with %1?

  • Reference in EAV module.
    "Invalid attribute identifier for filter (' . get_class($attribute) . ","Invalid attribute identifier for filter (' . get_class($attribute) . "

I think the text shouldn't join with "."

  • Reference in Paygate module.
    "Credit Card %s","Credit Card %s"

Shouldn't %d, %s replaced with %1?
@verklov
Copy link
Contributor

verklov commented Nov 29, 2013

Hello guoguolong,
Thank you for reporting this issue! Out team will review it and come up with a solution once it is confirmed.

magento-team added a commit that referenced this issue Mar 7, 2014
@magento-team
2.0.0.0-dev68
c6856aa 
* Cache:
  * Implemented depersonalization of private content generation
  * Implemented content invalidation
  * Added Edge Side Includes (ESI) support
  * Added a built-in caching application
* GitHub requests:
  * [#454](#454) -- Allow to specify list of IPs in a body on maintenance.flag which will be granted access even if the flag is on
  * [#204](#204) -- Mage_ImportExport: Exporting configurable products ignores multiple configurable options
  * [#418](#418) -- Echo vs print
  * [#419](#419) -- Some translation keys are not correct.
  * [#244](#244) -- Retrieve base host URL without path in error processor
  * [#411](#411) -- Missed column 'payment_method' of table 'sales_flat_quote_address'
  * [#284](#284) -- Fix for Issue #278 (Import -> Stores with large amount of Configurable Products)
* Fixed bugs:
  * Fixed an issue where Mage_Eav_Model_Entity_Type::fetchNewIncrementId() did not rollback on exception
  * Fixed an issue where a category containing more than 1000 products could not be saved
  * Fixed inappropriate error messages displayed during installation when required extensions were not installed
  * Fixed synopsis of the install.php script
  * Fixed an issue where the schedule of recurring payments was not displayed in the shopping cart
* Modularity improvements:
  * Introduced the OfflinePayments module - a saparate module for offline payment methods
  * Added the ability to enable/disable the Paypal module
  * Moved the framework part of the Locale functionality from the Core module to library
  * The Locale logic was split among appropriate classes in library, according to their responsibilities
  * Removed the deprecated DHL functionality
  * Introduced the OfflineShipping module for offline shipping carrier functionality: Flatrate, Tablerate, Freeshipping, Pickup
  * Introduced a separate module for the DHL shipping carrier
  * Introduced a separate module for the Fedex shipping carrier
  * Introduced a separate module for the UPS shipping carrier
  * Introduced a separate module for the USPS shipping carrier
* Framework Improvements:
  * Added the ability to intercept internal public calls
  * Added the ability to access public interface of the intercepted object
  * Added a static integrity test for plugin interface validation
  * Added support for both class addressing approaches in DI: with and without slash ("\") at the beginning of a class name
* Customer Service usage:
  * Refactored the Customer module blocks and controllers to use customer service layer
* Security:
  * Introduced the ability to hash a password with a random salt of default length (32 chars) by the encryption library
  * Utilized a random salt of default length for admin users, and frontend customers
@verklov
Copy link
Contributor

verklov commented Mar 8, 2014

@guoguolong, we have fixed this issue. The code has been released in dev68.

@verklov verklov closed this as completed Mar 8, 2014
magento-team pushed a commit that referenced this issue Jul 15, 2015
Merge pull request #419 from magento-vanilla/PR
8b5026a 
[Vanilla] Bugsfixes
magento-team pushed a commit that referenced this issue Mar 19, 2016
@magicbunneh
Merge pull request #419 from magento-tango/MAGETWO-50128
432b39b 
[Tango] Configurable Product, Product Attributes, Bug Fixes
mmansoor-magento pushed a commit that referenced this issue Sep 22, 2016
@heyitsroberthe
Merge pull request #419 from magento-jackalopes/ft-pr-new
2c22ac4 
[Jackalopes] FT - Variations and Constraints Review
magento-devops-reposync-svc pushed a commit that referenced this issue May 24, 2022
@slopukhov
Merge pull request #419 from magento-performance/cabpi-332-revoke-ims…
60ebe86 
…-token-on-force-sign-in

Cabpi 332 revoke ims token on force sign in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guoguolong @verklov