Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console installer doesn't checks filesystem permissions #548

Closed
ihor-sviziev opened this issue Apr 14, 2014 · 3 comments
Closed

Console installer doesn't checks filesystem permissions #548

ihor-sviziev opened this issue Apr 14, 2014 · 3 comments
Assignees
@verklov
Labels
improvement

Comments

@ihor-sviziev
Copy link
Contributor

I tried perform installation from console by dev/shell/install.php file. Magento successfully installed, but I have some issues with styles.
Then I removed Magento & installed from browser wizard, and it showed me lot errors like this:

Path "app/etc" must be writable.
Path "pub/media" must be writable.
Path "pub/media/customer" must be writable.
Path "pub/media/downloadable" must be writable.
Path "pub/media/theme_customization" must be writable.

I think we should add this checks to console installer.
@verklov verklov self-assigned this Apr 15, 2014
@verklov
Copy link
Contributor

verklov commented Apr 15, 2014

@igor-svizev, thank you for the suggestion! This looks like a good thing to have for the console installer. Having permission errors on console installation would be quite useful for people like me, who can forget about the necessary permissions that must be set for specific directories. I will add this as an improvement to the product backlog.

magento-team added a commit that referenced this issue Jun 16, 2014
@magento-team
2.0.0.0-dev82
658b76f 
* Added support for MTF Reporting Tool
* Framework improvements:
  * Covered the following Magento application components with unit tests:
      * `ConfigurableProduct/Helper/Data.php`
      * `ConfigurableProduct/Model/Export/RowCustomizer.php`
      * `ConfigurableProduct/Model/Product/Type/Configurable.php`
      * `ConfigurableProduct/Model/Product/Type/Plugin.php`
      * `ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProduct.php`
      * `CatalogSearch/Helper/Data.php`
  * Covered Magento lib with unit tests:
      * `lib/internal/Magento/Framework/DB/Helper/AbstractHelper.php`
      * `lib/internal/Magento/Framework/DB/Tree/Node.php`
* Created Service API for Magento_Catalog Module:
  * Implemented the Product API
  * Implemented the ProductAttributeRead API
* Fixed bugs:
  * Fixed issues with form elements visibility on the backend
  * Fixed an issue where backend forms contained an excessive container
  * Fixed an issue where a wrong category structure was displayed on the Category page
  * Fixed an issue where the pub/index.php entry point was broken because of the obsolete constants
  * Fixed an issue where it was impossible to pass an empty array as an argument in DI configuration and layout updates
  * Fixed an issue with status and visibility settings of a related product on the backend
  * Fixed an issue with unused DB indexes, which used resources, but did not contribute to higher performance
  * Fixed an issue where it was possible to create a downloadable product without specifying a link or a file
  * Fixed an issue where a fatal error occured when opening a fixed bundle product with custom options page on the frontend
  * Fixed an issue where the was a wrong config key for backend cataloginventory
* Processed GitHub requests:
  * [#548] (#548) -- Console installer doesn't checks filesystem permissions
  * [#552] (#552) -- backend notifications sitebuild bug
  * [#562] (#562) -- Bugfix Magento\Framework\DB\Adapter\Pdo\Mysql::getCreateTable()
  * [#565] (#565) -- Magento\CatalogSearch\Model\Query::getResultCollection() not working
  * [#557] (#557) -- translation anomalies backend login page
* Added the following functional tests:
  * Advanced Search
  * Existing Customer Creation
  * Product Attribute Creation
  * Product Rating Creation
  * Sales Rule Creation
  * System Product Attribute Deletion
  * Tax Rate Creation
  * Tax Rule Deletion
  * Update Category
  * Update Category Url Rewrite
  * Update Product Url Rewrite
@verklov
Copy link
Contributor

verklov commented Jun 26, 2014

@igor-svizev, please verify the fix we deployed in dev82. Thank you again for reporting it! We are closing this issue.

@verklov verklov closed this as completed Jun 26, 2014
@wojtekn
Copy link
Contributor

wojtekn commented Dec 14, 2014

It looks that this doesn't help too much if web server runs using different user than PHP CLI. If user installs Magento using CLI, installer positively verifies directories as writable and proceeds with installation. Then Magento throws an error when run in browser.

It was "pub/static/_requirejs/frontend/Magento/blank/en_US" in my case. Is there any plan on that?

magento-team pushed a commit that referenced this issue Apr 18, 2016
Merge pull request #548 from magento-qmt/MTA-3295
9880a3a 
[Mavericks] [Github] Security issue that Php files are executable
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Merge pull request #548 from magento-dragons/DRAGONS-PR2.0
39229d6 
Fixed issues:
 - MAGETWO-59050 Portdown MAGETWO-50198 to 2.0
 - MAGETWO-59829 [Backport] Product import with images not working
magento-engcom-team added a commit that referenced this issue Mar 30, 2019
@magento-engcom-team
ENGCOM-4614: magento/graphql-ce#547: 547 - ProductFilterInput. Remove…
c36e369 
… duplicate 'special_price' field #548

 - Merge Pull Request magento/graphql-ce#548 from magento/graphql-ce:547-ProductFilterInput-Remove-duplicate-special_price
 - Merged commits:
   1. 33d0522
magento-engcom-team pushed a commit that referenced this issue Mar 30, 2019
@naydav
ENGCOM-4614: magento/graphql-ce#547: 547 - ProductFilterInput. Remove…
de62fbe 
… duplicate "special_price" field #548
magento-devops-reposync-svc pushed a commit that referenced this issue Sep 8, 2023
@andimov
Merge pull request #548 from magento-performance/ACPT-1363
0d00c69 
ACPT-1363: Fix Directory WebApi GraphQL tests on Application Server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verklov verklov

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wojtekn @ihor-sviziev @verklov