Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use private for message ? #6

Closed
stephpy opened this issue Mar 2, 2012 · 1 comment
Closed

Why use private for message ? #6

stephpy opened this issue Mar 2, 2012 · 1 comment

Comments

@stephpy
Copy link

stephpy commented Mar 2, 2012

On this class:

https://github.com/magento/magento2/blob/master/app/code/core/Mage/Checkout/Model/Type/Onepage.php

Why $_customerEmailExistsMessage is defined as private, there is no setter and _customerEmailExistsMessage is setted from constructor statically.

The only one possibility we have to change this message is to play with i18n.

Is there a reason ? I think this property should be protected. No ?

@magento-team
Copy link
Contributor

Hi stephpy. Thanks for the feedback.

It appears that there was no specific reason to make it private. It has been changed to protected (will be rolled out with one of the next code update).

maksek pushed a commit that referenced this issue Dec 26, 2014
[Mavericks] Re-factor end-to-end search tests and fix symlinks while factory generation
This was referenced Jan 24, 2015
@alicedfisheye alicedfisheye mentioned this issue May 14, 2024
5 tasks
@FabXav FabXav mentioned this issue Oct 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants