Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why don't getAllIds() of Mage_Core_Model_Resource_Db_Collection_Abstract bind params? #60

Closed
SunshineTech opened this issue Aug 6, 2012 · 1 comment
Closed

Why don't getAllIds() of Mage_Core_Model_Resource_Db_Collection_Abstract bind params? #60

SunshineTech opened this issue Aug 6, 2012 · 1 comment

Comments

@SunshineTech
Copy link

In the end of getAllIds() of Mage_Core_Model_Resource_Db_Collection_Abstract, it is:
(line 499)
return $this->getConnection()->fetchCol($idsSelect);

Why isn't it the following:

return $this->getConnection()->fetchCol($idsSelect, $this->_bindParams);
@magento-team
Copy link
Contributor

@SunshineTech , thank you for the suggestion. It is fixed and will be available on GitHub with one of the next updates.

magento-team added a commit that referenced this issue Sep 14, 2012
@magento-team
Update as of 9/13/2012
da072ba 
* Implemented the option to enable the single store mode in the system configuration, which simplifies the back-end GUI:
  * Hiding scope labels from the system configuration
  * Hiding the scope switcher from the CMS management pages and the system configuration
  * Hiding scope related fields from the system configuration
  * Hiding scope related columns and fields from the sales pages (order, invoice, shipment pages)
  * Hiding scope related fields from the promotions
  * Hiding scope related fields from the catalog pages
  * Hiding scope related columns and fields from the customers management page
  * Hiding scope related columns and fields from the customer and customer address attributes management pages
* Implemented the history management for the Visual Design Editor
* Implemented the user interface for themes management, which allows to list existing themes and add new ones
* Replaced all usages of the old JavaScript translations mechanism with the new jQuery one
* Refactored methods with high cyclomatic complexity
* Converted some surrogate integration tests into functional Selenium tests
* Converted some surrogate integration tests into unit tests
* Fixes:
  * Fixed inability to install application with a prefix defined for database tables
  * Fixed displaying fields with model name in the payment methods settings
  * Fixed performance degradation of the back-end menu rendering
  * Fixed absence of the success message upon newsletter template creation/deletion/queueing
  * Workaround for occasional segmentation fault in integration tests caused by `Mage_Core_Model_Resource_Setup_Migration`
* GitHub requests:
  * [#51](#51) -- fixed managing of scope-spefic values for Categories
  * [#56](#56) -- removed excessive semicolon in the CSS file
  * [#60](#60) -- fixed taking bind parameters into account in `Mage_Core_Model_Resource_Db_Collection_Abstract::getAllIds()`
  * [#61](#61) -- relocated declaration of the "Google Checkout" payment method into `Mage_GoogleCheckout` module from `Mage_Sales`
@leeyisoft leeyisoft mentioned this issue Jun 14, 2014
Closed
vpelipenko added a commit that referenced this issue Jan 30, 2015
@vpelipenko
Merge pull request #60 from magento-tango/MAGETWO-31522
8892e7b 
[Tango] S45 Controller Refactoring
@stevieyu stevieyu mentioned this issue Apr 3, 2015
Closed
@pccomfrank pccomfrank mentioned this issue Jun 2, 2015
Closed
@vinhtrau vinhtrau mentioned this issue Jul 4, 2015
Closed
@sivajik34 sivajik34 mentioned this issue Jul 13, 2015
Closed
@ljrweb ljrweb mentioned this issue Sep 9, 2015
Closed
@LifeAsBook LifeAsBook mentioned this issue Sep 10, 2015
Closed
@chrom chrom mentioned this issue Oct 7, 2015
Closed
@chaluvadiswamy chaluvadiswamy mentioned this issue Nov 3, 2015
Closed
This was referenced Nov 22, 2015
Closed
Closed
@thomvanderboon thomvanderboon mentioned this issue Nov 29, 2015
Closed
@jiramlopez jiramlopez mentioned this issue Dec 3, 2015
Closed
@oaramis oaramis mentioned this issue Dec 22, 2015
Closed
@Fel1xx Fel1xx mentioned this issue Feb 12, 2016
Closed
@echh echh mentioned this issue Feb 17, 2016
Closed
@gnusmus gnusmus mentioned this issue Mar 1, 2016
Closed
@jaimestuardo jaimestuardo mentioned this issue Apr 13, 2016
Closed
@ghost ghost mentioned this issue Jun 3, 2016
Closed
@wangyonglin wangyonglin mentioned this issue Jun 17, 2016
Closed
@salelsol salelsol mentioned this issue Jun 30, 2016
Closed
@wallabit wallabit mentioned this issue Jul 10, 2016
Closed
@lhsatch lhsatch mentioned this issue Jul 22, 2016
Closed
@GiriManas GiriManas mentioned this issue Aug 8, 2016
Closed
@NikolasSumrak NikolasSumrak mentioned this issue Aug 30, 2016
Merged
@abi2 abi2 mentioned this issue Sep 19, 2016
Closed
@angelo983 angelo983 mentioned this issue Jul 24, 2017
Closed
@erik-augustin erik-augustin mentioned this issue Aug 15, 2017
Closed
@pareshpa pareshpa mentioned this issue Sep 26, 2017
Closed
@AmastyLtd-zz AmastyLtd-zz mentioned this issue Oct 10, 2017
Closed
@ghost ghost mentioned this issue Oct 21, 2017
Closed
@pradeepnew pradeepnew mentioned this issue Nov 30, 2017
Closed
@wcldharamveer wcldharamveer mentioned this issue Jan 9, 2018
Closed
@kamal7606 kamal7606 mentioned this issue Feb 12, 2018
Closed
@primzonltd primzonltd mentioned this issue Feb 12, 2018
Closed
@ghost ghost mentioned this issue May 3, 2018
Closed
@Jaydeepjd Jaydeepjd mentioned this issue May 22, 2018
Closed
@sabl0r sabl0r mentioned this issue Aug 14, 2018
Closed
magento-engcom-team pushed a commit that referenced this issue Aug 27, 2018
@nikshostko
Merge pull request #60 from magento-epam/SPRINT-1-MAGETWO-66666
bbfc4b8 
MAGETWO-66666: Adding a product to cart from category page with an ex…
@albsa albsa mentioned this issue Sep 26, 2018
Closed
@Microguru Microguru mentioned this issue Sep 27, 2018
Closed
@pskigen pskigen mentioned this issue Dec 14, 2018
Closed
@lfluvisotto lfluvisotto mentioned this issue Apr 7, 2019
Closed
@mohanwbsofttech mohanwbsofttech mentioned this issue Dec 30, 2020
Closed
@eBusinessAtlantique eBusinessAtlantique mentioned this issue May 20, 2021
Closed
@jpillai88 jpillai88 mentioned this issue May 21, 2021
Closed
@mtjweb mtjweb mentioned this issue Jun 25, 2021
Closed
5 tasks
@ghost ghost mentioned this issue Jun 28, 2021
Closed
1 task
@jorgb90 jorgb90 mentioned this issue Apr 29, 2022
Closed
5 tasks
@mohammedTBB mohammedTBB mentioned this issue Sep 7, 2022
Closed
5 tasks
@mohammedTBB mohammedTBB mentioned this issue Sep 15, 2022
Closed
5 tasks
@kisfelix kisfelix mentioned this issue Apr 4, 2023
Closed
5 tasks
@KhanBadshah588 KhanBadshah588 mentioned this issue Oct 6, 2023
Closed
5 tasks
Closed
5 tasks
@iranimij iranimij mentioned this issue Nov 21, 2023
Closed
5 tasks
@FabXav FabXav mentioned this issue Oct 11, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magento-team @SunshineTech